This repository was archived by the owner on Jan 11, 2024. It is now read-only.
Move test publishing from post-build to pre-test-run#1081
Merged
weshaggard merged 1 commit intodotnet:masterfrom Oct 1, 2016
Merged
Move test publishing from post-build to pre-test-run#1081weshaggard merged 1 commit intodotnet:masterfrom
weshaggard merged 1 commit intodotnet:masterfrom
Conversation
Currently test publishing happens during PrepareForRun which is a post step of build. However we need TestTFM as a parameter in test publishing which we don't know until test runtime because a given test build can have a set of TestTFM's that apply to it. To address this we are moving test publishing as a pre-step for test running. To do this we are overriding the Test target and adding a set of DependsOnTargets to allow for ordering them correctly.
weshaggard
added a commit
to weshaggard/corefx
that referenced
this pull request
Oct 1, 2016
This is primarily to pull in change dotnet/buildtools#1081
weshaggard
added a commit
to weshaggard/corefx
that referenced
this pull request
Oct 1, 2016
This is primarily to pull in change dotnet/buildtools#1081
Member
|
LGTM. thanks Wes for cleaning up this. |
weshaggard
added a commit
to weshaggard/corefx
that referenced
this pull request
Oct 3, 2016
This is primarily to pull in change dotnet/buildtools#1081
weshaggard
added a commit
to dotnet/corefx
that referenced
this pull request
Oct 3, 2016
* Update build tools to 901-01 This is primarily to pull in change dotnet/buildtools#1081 * Remove PrepareForRun from the target list when running Tests We no longer need PrepareForRun to go before our Test target and in fact it causes issues with the ordering of ProjectReference evaluation so we need to remove it from our traversal targets.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Update build tools to 901-01 This is primarily to pull in change dotnet/buildtools#1081 * Remove PrepareForRun from the target list when running Tests We no longer need PrepareForRun to go before our Test target and in fact it causes issues with the ordering of ProjectReference evaluation so we need to remove it from our traversal targets. Commit migrated from dotnet/corefx@a5ab071
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently test publishing happens during PrepareForRun which is a
post step of build. However we need TestTFM as a parameter in test
publishing which we don't know until test runtime because a given
test build can have a set of TestTFM's that apply to it. To address
this we are moving test publishing as a pre-step for test running.
To do this we are overriding the Test target and adding a set of
DependsOnTargets to allow for ordering them correctly.
cc @joperezr @tarekgh
fyi @stephentoub this should fix the issue we saw with CodeDom tests.