This repository was archived by the owner on Jan 11, 2024. It is now read-only.
Workaround netcore roslyn assembly loading issue#1185
Merged
mellinoe merged 1 commit intodotnet:masterfrom Nov 1, 2016
Merged
Conversation
Roslyn on .NETCore wasn't finding dependencies of analyzers if those dependencies were not in the same directory as CSC itself. It should be looking next to the analyzer but is not.
alexperovich
approved these changes
Nov 1, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roslyn on .NETCore wasn't finding dependencies of analyzers if those
dependencies were not in the same directory as CSC itself. It should be
looking next to the analyzer but is not.
On desktop this happens automatically but on Core I suspect roslyn's AssemblyLoadContext needs to handle it.
Workaround that by copying these dependencies to lib temporarily.
/cc @alexperovich @tmat @tmeschter @mavasani