This repository was archived by the owner on Jan 11, 2024. It is now read-only.
Move Inbox data to package index#1337
Merged
Merged
Conversation
Previously we'd null-ref. That was wrong, additionally the error is wrong in light of NETStandard 2.0. We can now have a reference that intententionally has no dependencies.
This removes the use of framework lists to define which packages are inbox. Instead we'll let that data live with the repro consuming buildtools and be part of the PackageIndex. I've added arguments to UpdatePackageIndex that let folks migrate. I've done the migration for corefx and tested that this behaves as expected. While doing this I also made some changes to make the index more readable by sorting various things (package list, version list, etc).
These are no longer needed by any of our workflows and result in a lot of wasted build time.
We already have overlap between Packaging.targets and PackageLibs.targets. Packaging.targets is only imported for pkgprojs while PackageLibs.targets is always imported but is imported after Packaging.targets. This common targets allows us to share source between the two with the correct evaluation sequence.
This moves some shared properties and using tasks to the shared targets file.
In some cases we want to build the RID off of two independent properties (OSGroup and TargetGroup) each of which contribute a different portion (eg: win and aot).
CROSS Risk ReportGenerated: 2/16/2017 10:03:04 AM High Risk Files
Risk Score Totals Total score for high risk files: 70 Total execution time: 1.92 seconds |
weshaggard
reviewed
Feb 21, 2017
|
|
||
| <!-- Installs locally built package into a packageinstalldir for consuming --> | ||
| <!-- Overwrites previous installs, supports only one version installed --> | ||
| <Target Name="InstallLocallyBuiltPackages" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're growing the inbox concept to accomodate the flat framework packages (eg: NETStandard.Library, MS.NETCore.App, UWP). As such it no longer makes sense to have these things defined as static framework lists that live in the buildtools package. I've moved the data into the packageindex and created mechanisms for migration.
/cc @weshaggard @joperezr