This repository was archived by the owner on Jan 11, 2024. It is now read-only.
Update submodules from ProdCon orchestrated build manifests#1968
Merged
Conversation
Adds an updater and dependency info that allow updating submodules from an orchestrated build manifest created by a successful ProdCon build.
Member
Author
|
Wes had a comment on the source-build commit that I'm going to take a stab at before merging this PR: dagood/source-build@4791893#r28179476. (Including an updater for the checked-in commit info in the project files.) |
dseefeld
approved these changes
Mar 20, 2018
|
/cc @markwilkie since this should eventually move to arcade. |
Member
Author
|
Eric pinged me about that too offline, it's tracked by dotnet/arcade#32. |
Member
Author
|
I split off a new issue for the project file hard-coded metadata updater (commit hash, depth): dotnet/source-build#370. The API I wanted isn't available so I think what I end up with will deserve its own PR/review. Thanks, merging. |
This was referenced Mar 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be used by source-build to move the submodules to the hashes that were successful in the latest orchestrated build.
Setting this up in source-build: dagood/source-build@4791893. To avoid duplicating info outside the project files, I used the MSBuild task and Target output flow @eerhardt suggested a while back.
dotnet/source-build#342