Skip to content
This repository was archived by the owner on Jan 11, 2024. It is now read-only.

Get runtime OS info to add xunit categories.#564

Merged
Priya91 merged 1 commit intodotnet:masterfrom
Priya91:osgroup
Mar 23, 2016
Merged

Get runtime OS info to add xunit categories.#564
Priya91 merged 1 commit intodotnet:masterfrom
Priya91:osgroup

Conversation

@Priya91
Copy link

@Priya91 Priya91 commented Mar 23, 2016

weshaggard
weshaggard reviewed Mar 23, 2016
View reviewed changes
src/Microsoft.DotNet.Build.Tasks.net45/project.json
"System.Collections.Immutable": "1.1.37",
"System.Reflection.Metadata": "1.1.0",
"Microsoft.NETCore.Platforms": "1.0.1-rc2-23907",
"System.Runtime.InteropServices.RuntimeInformation": "4.0.0-rc2-23907"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@weshaggard
Copy link
Member

weshaggard commented Mar 23, 2016

FYI @sokket

Thanks for doing this @Priya91 this looks good to me beyond my one concern about it working in our internal builds. We need to make sure that task library doesn't break there.

weshaggard
weshaggard reviewed Mar 23, 2016
View reviewed changes
src/Microsoft.DotNet.Build.Tasks.net45/project.json
"System.Runtime.InteropServices.RuntimeInformation": "4.0.0-rc2-23907"
},
"frameworks": {
"net46": { }

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@Priya91
Copy link
Author

Priya91 commented Mar 23, 2016

@weshaggard I also verified by building and running tests on TFS, it didnt cause build break.

@Priya91 Priya91 merged commit 1be72a4 into dotnet:master Mar 23, 2016
@Priya91 Priya91 deleted the osgroup branch March 23, 2016 01:30
@weshaggard weshaggard mentioned this pull request Mar 25, 2016
Merged
rainersigwald pushed a commit to rainersigwald/buildtools that referenced this pull request Apr 25, 2018
@jkotalik
Improve error message when korebuild fails due to insufficient depend…
963ff94 
…encies (dotnet#564)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PlatformSpecific tests for AnyOS assemblies running incorrectly

4 participants

@Priya91 @weshaggard @ericstj @dnfclas