Skip to content
This repository was archived by the owner on Mar 23, 2021. It is now read-only.

Upgrade to RepoToolset SDK#68

Merged
tmat merged 1 commit into
dotnet:release/2.1.3xxfrom
tmat:RTSDK
Apr 26, 2018
Merged

Upgrade to RepoToolset SDK#68
tmat merged 1 commit into
dotnet:release/2.1.3xxfrom
tmat:RTSDK

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Mar 30, 2018 •
edited
Loading

@tmat tmat force-pushed the RTSDK branch 2 times, most recently from bda8067 to eaeba58 Compare April 4, 2018 22:41
@tmat tmat closed this Apr 4, 2018
@tmat tmat reopened this Apr 4, 2018
@tmat tmat closed this Apr 5, 2018
@tmat tmat reopened this Apr 5, 2018
@tmat tmat force-pushed the RTSDK branch 2 times, most recently from cca8ed7 to b35f0b6 Compare April 5, 2018 18:44
@tmat tmat mentioned this pull request Apr 5, 2018
Closed
livarcocc
livarcocc reviewed Apr 5, 2018
View reviewed changes
Comment thread .vsts-ci.yml
demands: Cmd
variables:
BuildConfiguration: Release
TeamName: Roslyn-Project-System

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

livarcocc
livarcocc reviewed Apr 5, 2018
View reviewed changes
Comment thread global.json
@@ -0,0 +1,8 @@
{

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

livarcocc
livarcocc reviewed Apr 5, 2018
View reviewed changes
Comment thread src/Tests/dotnet-migrate.Tests/GivenThatIWantToMigrateTestApps.cs Outdated
{
public class GivenThatIWantToMigrateTestApps : TestBase
{
{

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@livarcocc
Copy link
Copy Markdown
Contributor

livarcocc commented Apr 5, 2018

Also, same thing here, can this wait until we have the preview2 build cut out instead of risking de-stabilizing prodcon?

cc @mmitche

@mmitche
Copy link
Copy Markdown
Member

mmitche commented Apr 6, 2018

Yes, this cannot go in right now as we are in escrow.

@dagood
Copy link
Copy Markdown
Member

dagood commented Apr 24, 2018

Can this be merged now?

dagood
dagood reviewed Apr 24, 2018
View reviewed changes
Comment thread global.json
@@ -0,0 +1,8 @@
{
"sdk": {
"version": "2.1.101"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@livarcocc
Copy link
Copy Markdown
Contributor

livarcocc commented Apr 24, 2018

@mmitche to confirm it is ok to merge this change.

@mmitche
Copy link
Copy Markdown
Member

mmitche commented Apr 24, 2018

What's the risk? If low, I'm okay with taking it.

@dagood dagood mentioned this pull request Apr 25, 2018
Closed
@mmitche
Copy link
Copy Markdown
Member

mmitche commented Apr 26, 2018

I'm good to merge this.

@tmat tmat merged commit 578366e into dotnet:release/2.1.3xx Apr 26, 2018
@tmat tmat deleted the RTSDK branch April 26, 2018 16:49
@dagood dagood mentioned this pull request Jun 7, 2018
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@livarcocc livarcocc livarcocc approved these changes

@dagood dagood dagood left review comments

@jeffkl jeffkl jeffkl left review comments

@mmitche mmitche mmitche approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tmat @livarcocc @mmitche @dagood @jeffkl