Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Enable VB for dotnet cli 1.1#7032

Merged
livarcocc merged 1 commit intodotnet:rel/1.1.0from
KevinRansom:vb
Jun 30, 2017
Merged

Enable VB for dotnet cli 1.1#7032
livarcocc merged 1 commit intodotnet:rel/1.1.0from
KevinRansom:vb

Conversation

@KevinRansom
Copy link
Copy Markdown

Enable VB in dotnet cli 1.1.0

@livarcocc @nguerrera @srivatsn @AnthonyDGreen

@dnfclas
Copy link
Copy Markdown

dnfclas commented Jun 29, 2017

@KevinRansom,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@nguerrera
Copy link
Copy Markdown
Contributor

Fill out template and tag Matt.

@KevinRansom
Copy link
Copy Markdown
Author

KevinRansom commented Jun 29, 2017

Tagging @MattGertz for approval pending CI tests.

Customer scenario: VS ships with the V1.1 sdk and dotnet CLI without this change netstandard libraries and apps will not be editable in VS.

Workarounds, if any: Manually finding and installing dotnet sdk 2.0.

Risk:: Low

Performance impact : None only enabled for .vbproj

Is this a regression from a previous update?:, dotnet core support hasn't been provided in the past.

*Root cause analysis : Not yet implemented

How was this bug found?: Not yet implemented

@nguerrera
Copy link
Copy Markdown
Contributor

Performance impact : None only enabled for .fsproj

.vbproj, right?

@KevinRansom
Copy link
Copy Markdown
Author

@nguerrera yup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants