Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Update Template Engine and templates for 1.x#7039

Closed
mlorbetske wants to merge 2 commits intodotnet:rel/1.1.0from
mlorbetske:dev/mlorbe/UpdateTemplateEngineFor1x
Closed

Update Template Engine and templates for 1.x#7039
mlorbetske wants to merge 2 commits intodotnet:rel/1.1.0from
mlorbetske:dev/mlorbe/UpdateTemplateEngineFor1x

Conversation

@mlorbetske
Copy link
Copy Markdown

@mlorbetske mlorbetske force-pushed the dev/mlorbe/UpdateTemplateEngineFor1x branch from 0a2683c to 0dd4f12 Compare June 30, 2017 02:10
@mlorbetske
Copy link
Copy Markdown
Author

It looks like these are all failing for the F# templates due to duplicate compile items (from the implicit globs in the SDK & the explicit ones that specify the ordered items for compile).

@KevinRansom should the templates not have the compile items to get the fs files in some order or should the implicit globs for F# be removed?

19:36:38                      /Users/dotnet-bot/j/workspace/dotnet_cli/rel_1.1.0/release_osx_x64_prtest/artifacts/osx.10.11-x64/stage2/sdk/1.1.0-preview1-005066/Sdks/Microsoft.NET.Sdk/build/Microsoft.NET.Sdk.DefaultItems.targets(165,5): error : Duplicate 'Compile' items were included. The .NET SDK includes 'Compile' items from your project directory by default. You can either remove these items from your project file, or set the 'EnableDefaultCompileItems' property to 'false' if you want to explicitly include them in your project file. For more information, see https://aka.ms/sdkimplicititems. The duplicate items were: 'Program.fs' [/Users/dotnet-bot/j/workspace/dotnet_cli/rel_1.1.0/release_osx_x64_prtest/test/dotnet-new.Tests/bin/Release/netcoreapp1.1/TemplateRestoresAndBuildsWithoutWarningsF#_console/TemplateRestoresAndBuildsWithoutWarningsF#_console.fsproj] [/Users/dotnet-bot/j/workspace/dotnet_cli/rel_1.1.0/release_osx_x64_prtest/build/test/RunTest.proj]

@KevinRansom
Copy link
Copy Markdown

@mlorbetske I expect you are suffering from 1.1 not having the F# dotnet sdk updates.

@livarcocc ... I pulled the PR with the F# sdk updates just now. The dependency needs to be updated, before Mike can pull this. Or Mike can disable the f# tests, and we re-enable them as soon as the sdk is updated.

Kevin

This SDK contains the F# targets.
@livarcocc
Copy link
Copy Markdown

@KevinRansom @mlorbetske I have updated this PR with the new SDK.

@livarcocc livarcocc added this to the 2.0.0 milestone Jun 30, 2017
@livarcocc
Copy link
Copy Markdown

@MattGertz This will require an insertion into VS and this will enable the F# scenarios with the CLI in the box with VS.

@MattGertz
Copy link
Copy Markdown

Approved per JoC's F# approval yesterday.

@livarcocc
Copy link
Copy Markdown

Closing this one in favor of #7046.

@livarcocc livarcocc closed this Jun 30, 2017
@mlorbetske mlorbetske deleted the dev/mlorbe/UpdateTemplateEngineFor1x branch July 3, 2017 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants