Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Producing a nupkg for Microsoft.NET.MSBuildResolver.#7223

Merged
nguerrera merged 1 commit intodotnet:release/2.0.0from
livarcocc:resolver_nupkg
Jul 24, 2017
Merged

Producing a nupkg for Microsoft.NET.MSBuildResolver.#7223
nguerrera merged 1 commit intodotnet:release/2.0.0from
livarcocc:resolver_nupkg

Conversation

@livarcocc
Copy link
Copy Markdown

@livarcocc livarcocc commented Jul 21, 2017

Producing a nupkg for Microsoft.NET.MSBuildResolver. Note that this package contains only the Resolver dll. The hostfxr dll will still have to be acquired separately.

Fixes https://github.com/dotnet/cli/issues/7151

@dotnet/dotnet-cli @nguerrera

@srivatsn Infra-structure change only. We are producing one extra package.

…ackage contains only the Resolver dll. The hostfxr dll will still have to be acquired separately.
@nguerrera
Copy link
Copy Markdown
Contributor

FYI. @DustinCampbell

@nguerrera nguerrera merged commit 5d07534 into dotnet:release/2.0.0 Jul 24, 2017
@nguerrera
Copy link
Copy Markdown
Contributor

Package name is actually Microsoft.DotNet.MSBuildSdkResolver and will be pushed to https://dotnet.myget.org/gallery/dotnet-cli

@DustinCampbell
Copy link
Copy Markdown
Member

Will this eventually be published to nuget.org?

@DustinCampbell
Copy link
Copy Markdown
Member

Since the native dependencies have to be acquired separately, I'm guessing not. 😄

@nguerrera
Copy link
Copy Markdown
Contributor

You guessed correctly. 😉

@DustinCampbell
Copy link
Copy Markdown
Member

I'm a good guesser

@DustinCampbell
Copy link
Copy Markdown
Member

FWIW, it's too bad that there isn't a linux-x86 version. I wonder what Mono is doing about that.

@nguerrera
Copy link
Copy Markdown
Contributor

@akoeplinger

@DustinCampbell
Copy link
Copy Markdown
Member

Out of curiosity, why are there net46 and netstandard1.5 versions of this assembly? I hope they're effectively the same and not platform-specific.

@DustinCampbell
Copy link
Copy Markdown
Member

Ugh. They're platform-specific. Sigh...

@nguerrera
Copy link
Copy Markdown
Contributor

We can fix the net46 version to not assume Windows if that's a blocker for you.

@DustinCampbell
Copy link
Copy Markdown
Member

DustinCampbell commented Oct 3, 2017

It's not a blocker, just a pain. I also have an allergic reaction to net46 packages that assume Windows when they don't actually need to. 😄

@akoeplinger
Copy link
Copy Markdown
Member

FWIW, it's too bad that there isn't a linux-x86 version. I wonder what Mono is doing about that.

Sorry for the delay. We're building/shipping our own version of the libhostfxr.so.

@DustinCampbell
Copy link
Copy Markdown
Member

FWIW, I'm not sure it makes much sense to have a linux-x86 version of the SDK Resolve since .NET Core doesn't support linux-x86.

@akoeplinger
Copy link
Copy Markdown
Member

akoeplinger commented Oct 10, 2017

@DustinCampbell we do, because msbuild tries to p/invoke into libhostfxr.so and would crash if that doesn't work

@DustinCampbell
Copy link
Copy Markdown
Member

Fair enough, though isn't that only because Microsoft.NET.MSBuildResolver is installed into the SdkResolvers folder?

@akoeplinger
Copy link
Copy Markdown
Member

Yes but afaik we couldn't change that because we package msbuild as an arch-independent package. Though now that I'm thinking about it I remember we just went with a rm -rf Microsoft.NET.MSBuildResolver hack in the postinstall of the package on unsupported architectures :)

So yes it may not make much sense at the moment but .NET Core could be ported to x86 Linux so I also see no reason to remove it.

@DustinCampbell
Copy link
Copy Markdown
Member

😄

Thanks for touching base here. That helps! I just wanted to be sure I'm covering all of my platforms in C# for VS Code.

@akoeplinger
Copy link
Copy Markdown
Member

soo I just checked and it seems we recently made the libhostfxr.so build work on all the architectures we care about so we removed the hack, i.e. we're ready once the .NET Core SDK arrives on powerpc64 😄

@DustinCampbell
Copy link
Copy Markdown
Member

LOL

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants