Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Passwords/keys should not be passed in the environment#7278

Merged
johnbeisner merged 1 commit intodotnet:masterfrom
johnbeisner:master
Jul 26, 2017
Merged

Passwords/keys should not be passed in the environment#7278
johnbeisner merged 1 commit intodotnet:masterfrom
johnbeisner:master

Conversation

@johnbeisner
Copy link
Copy Markdown

@johnbeisner johnbeisner commented Jul 26, 2017 •
edited
Loading

Passwords/keys should not be passed in the environment via a docker file.

  1. passwords/keys are to be represented as 'secret' variables in a VSO build definition
  2. the 'secret' variables is passed as a property on the appropriate command-line like so: "/p:GITHUB_PASSWORD=$(GITHUB_PASSWORD)"
  3. then accessed when needed in the build by the property

@dotnet/dotnet-cli

@johnbeisner johnbeisner added this to the 2.1.0 milestone Jul 26, 2017
@johnbeisner johnbeisner self-assigned this Jul 26, 2017
@johnbeisner johnbeisner merged commit 36394f4 into dotnet:master Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dsplaisted dsplaisted Awaiting requested review from dsplaisted

@livarcocc livarcocc Awaiting requested review from livarcocc

@wli3 wli3 Awaiting requested review from wli3

1 more reviewer

@nguerrera nguerrera nguerrera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@johnbeisner johnbeisner

Labels

Infrastructure

Projects

None yet

Milestone

2.1.3xx

Development

Successfully merging this pull request may close these issues.

3 participants

@johnbeisner @nguerrera @dnfclas