LOC CHECKIN | cli master | 20180315

[v-zbsail]

No description provided.

[peterhuene]

Unfortunately it looks like the list tool command tests are making some string length assumptions that are violated when the table header is localized. I'll see if I can create a fix for the failing tests.

[nguerrera]

@peterhuene if necessary you can do things conditioned on whether DotnetUnderTest.IsLocalized like we've done in a few places.

[nguerrera]

For things where testing the visual against an English rendering (help message) seemed most effective, I sacrificed the loc coverage.

[nguerrera]

There is also a BeVisuallyEquivalentIfNotLocalized helper I used in places.

[nguerrera]

Nevermind, I see you did the work to fix it and not lose coverage. :)

[peterhuene]

@v-zbsail If you rebase this PR off of master it should resolve hopefully resolve the test failures.

[nguerrera]

Shouldn't be necessary to rebase. Jenkins uses merge head.

[nguerrera]

@dotnet-bot test this please

[peterhuene]

That's good to know, thanks. I'm used to Travis for public repos.

[peterhuene]

@v-zbsail Unfortunately it looks like this needs to be rebased with changes that went into master recently. Will changed a few of the resource strings to make them clearer for users.

[nguerrera]

@peterhuene you can resolve this for him. That's the usual process. Accept conflicts in entirely in his favor then build to change things to needs-review etc. Push a commit.

[peterhuene]

@nguerrera will do.

[nguerrera]

Thanks

[peterhuene]

For strings being translated that have been modified in master, should I treat them still as new?

[nguerrera]

No accept his side of the conflict entirely (whole file) with "translated" then update xlf as usual and tooling will change to "needs-review-translation" which is correct.

[peterhuene]

Sorry, I had asked the question without fully reading your previous comment. Pushed up the rebase.