This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Better using facing string #8809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <trans-unit id="ToolPathDescription"> | ||
| <source>Location of shim to access tool</source> | ||
| <target state="new">Location of shim to access tool</target> | ||
| <source>LLocation where the tool will be installed.</source> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| <source>Location of shim to access tool</source> | ||
| <target state="new">Location of shim to access tool</target> | ||
| <source>LLocation where the tool will be installed.</source> | ||
| <target state="new">LLocation where the tool will be installed.</target> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| <source>Location of shim to access tool</source> | ||
| <target state="new">Location of shim to access tool</target> | ||
| <source>LLocation where the tool will be installed.</source> | ||
| <target state="new">LLocation where the tool will be installed.</target> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| <source>Location of shim to access tool</source> | ||
| <target state="new">Location of shim to access tool</target> | ||
| <source>LLocation where the tool will be installed.</source> | ||
| <target state="new">LLocation where the tool will be installed.</target> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| <trans-unit id="ToolPathDescription"> | ||
| <source>Location of shim to access tool</source> | ||
| <target state="new">Location of shim to access tool</target> | ||
| <source>LLocation where the tool will be installed.</source> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Author
|
@dotnet/dotnet-cli need an approval of this PR, thanks! |
peterhuene
reviewed
Mar 16, 2018
| </data> | ||
| <data name="ToolPathDescription" xml:space="preserve"> | ||
| <value>Location of shim to access tool</value> | ||
| <value>Location where the tool will be installed.</value> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
peterhuene
approved these changes
Mar 16, 2018
peterhuene
left a comment
peterhuene
left a comment
There was a problem hiding this comment.
Other than my comment above that needs to be fixed, looks good 👍
|
👍 |
peterhuene
pushed a commit
that referenced
this pull request
Mar 23, 2018
…elease/2.1.3xx-to-master * upstream/release/2.1.3xx: Try shorter test names Fix project type GUIDs when adding projects to solution files. Updating the runtime to 2.1.0-preview2-26314-02 Remove runtime identifiers from the test project Update launch settings for ApplicationUrl handling Change command order for tools (#8862) Update translations following merge with conflicts. LOC CHECKIN | cli master | 20180315 Implement the --tool-path option for the list tool command. Ensure tool package store root is a full path. Better using facing string (#8809) Fix list tool command tests to be localizable. Fix #4139 - escape quoted strings for process start Generate Microsoft.NETCoreSdk.BundledCliTools.props
peterhuene
pushed a commit
that referenced
this pull request
Mar 23, 2018
* upstream/release/2.1.3xx: Try shorter test names Fix project type GUIDs when adding projects to solution files. Updating the runtime to 2.1.0-preview2-26314-02 Remove runtime identifiers from the test project Update launch settings for ApplicationUrl handling Change command order for tools (#8862) Update translations following merge with conflicts. LOC CHECKIN | cli master | 20180315 Implement the --tool-path option for the list tool command. Ensure tool package store root is a full path. Better using facing string (#8809) Fix list tool command tests to be localizable. Fix #4139 - escape quoted strings for process start Generate Microsoft.NETCoreSdk.BundledCliTools.props
peterhuene
pushed a commit
that referenced
this pull request
Mar 23, 2018
* upstream/release/2.1.3xx: Try shorter test names Fix project type GUIDs when adding projects to solution files. Updating the runtime to 2.1.0-preview2-26314-02 Remove runtime identifiers from the test project Update launch settings for ApplicationUrl handling Change command order for tools (#8862) Update translations following merge with conflicts. LOC CHECKIN | cli master | 20180315 Implement the --tool-path option for the list tool command. Ensure tool package store root is a full path. Better using facing string (#8809) Fix list tool command tests to be localizable. Fix #4139 - escape quoted strings for process start Generate Microsoft.NETCoreSdk.BundledCliTools.props
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/dotnet/cli/issues/8728
Fix https://github.com/dotnet/cli/issues/8369