Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Conversation

@peterhuene
Copy link

This PR implements the missing --tool-path option for the list tool command. This enables the command to list locally installed tools.

Fixes #8803.

Also fixes #8829.

Peter Huene added 2 commits March 16, 2018 20:13
This commit fixes the tool package store such that it stores a full path
instead of, potentially, a relative path.

This prevents a relative path from inadvertently being passed to NuGet
during the restore and causing it to restore relative to the temp project
directory.

Fixes #8829.
This commit implements the missing `--tool-path` option for the list tool
command.  This enables the command to list locally installed tools.

Fixes #8803.
@peterhuene peterhuene requested review from a team and wli3 March 17, 2018 03:16
@peterhuene
Copy link
Author

@dotnet-bot test RHEL6 x64 Debug Build

@wli3
Copy link

wli3 commented Mar 17, 2018

Since we focus tool-path on CI, I don't think it is necessary for list at this stage. The output of list is not for machine to read. However, this is needed probably whatever comes the next iteration

@peterhuene peterhuene merged commit ec3bdf6 into dotnet:master Mar 19, 2018
@peterhuene peterhuene deleted the list-tool-path branch March 19, 2018 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool installation with relative --tool-path option fails to install. List tool should implement --tool-path option.

2 participants