This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Update launch settings for ApplicationUrl handling #8863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@dotnet-bot test Windows_NT x64 Release Build please |
|
@mlorbetske the failures seem to be legit on windows: the test that is failing is AppWithApplicationUrlInLaunchSettings. |
Author
|
@livarcocc it's strange, the error indicates that the runtimeconfig is not valid. I've removed the RIDs from the project file - hopefully that takes care of it |
|
@mlorbetske apparently... it did not. |
Author
|
I think i see, looks like it might be a MAX_PATH thing. Will try a shorter test project name. |
livarcocc
approved these changes
Mar 23, 2018
|
@MattGertz TELL |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @danroth27, if the user sets the environment variable in a launch profile for ASPNETCORE_URLS, it should override the value of ApplicationUrl. Added tests to check that behavior & verify that ApplicationUrl is being applied in general.