Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Conversation

@johnbeisner
Copy link

@johnbeisner johnbeisner commented Apr 9, 2018

Introduce support for arm & arm64 architectures; when detecting a missing 'library' prerequisite - do not fail the installation.

Addresses: https://github.com/dotnet/cli/issues/9007

Auto-detect tested successfully on:
OS = raspbian.8
Arch = armv7l

…sing 'library' prerequisite - do not fail the installation.
@johnbeisner johnbeisner self-assigned this Apr 9, 2018
@johnbeisner johnbeisner requested review from a team, janvorli, livarcocc, natemcmaster and wli3 April 9, 2018 23:06
@natemcmaster
Copy link

Any reason we can't use uname -m to detect arch? Here are some sample values. I'm sure there are more. We could always err if we don't recognize the arch.

Platform uname -m Rid
macOS x86_64 osx-x64
Ubuntu Bionic x64 x86_64 linux-x64
Ubuntu Bionic arm32v7 armv7l linux-arm
Ubuntu Bionic arm64v8 aarch64 linux-arm64

x86)
say_err "Architecture \`x86\` currently not supported"
return 1
arm|arm32)

This comment was marked as spam.

version="Latest"
install_dir="<auto>"
architecture="<auto>"
architecture="x64"

This comment was marked as spam.

@johnbeisner
Copy link
Author

johnbeisner commented Apr 10, 2018

@natemcmaster
@janvorli
In the current version; the default architecture is 'x64' when "auto" is used.

I can see the value in trying to recognize the architecture; however, I feel strongly that we need to default to 'x64' when "auto" is used instead of an error-out. We would, at minimum, risk breaking fringe x64 Linux platforms if we now error-out on a peculiar return-value from 'uname -m'.

@johnbeisner
Copy link
Author

@dotnet-bot Test RHEL7.2 x64 Release Build

@johnbeisner johnbeisner added this to the 2.1.3xx milestone Apr 11, 2018
@johnbeisner johnbeisner merged commit 996eb6c into dotnet:release/2.1.3xx Apr 11, 2018
@johnbeisner johnbeisner deleted the ScriptUpdate branch January 17, 2019 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants