This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Terminate the 'StartsWith' string in the badge existence check. #9049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
reviewed
Apr 11, 2018
| foreach (string img in badges.Keys) | ||
| { | ||
| if ((name.StartsWith($"{img}")) && (name.EndsWith(".svg"))) | ||
| if ((name.StartsWith($"{string.Concat(img, "_")}")) && (name.EndsWith(".svg"))) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Author
|
@dotnet/dotnet-cli |
dsplaisted
approved these changes
Apr 11, 2018
livarcocc
added a commit
to livarcocc/cli-1
that referenced
this pull request
Apr 16, 2018
* master: (49 commits) Add back 'nuget-build' feed for: NuGet.Versioning 4.7.0-rtm.5081 Slight re-ordering... Add back 'Roslyn' feed for: Microsoft.NETCore.Compilers 2.8.0-beta4-62811-05 Trim back the 'unnecessary' nuget feeds. Insert NuGet Build 4.7.0-rtm.5081 into cli Terminate the 'StartsWith' string in the badge existence check. (dotnet#9049) Update coresetup, coresetup, coresetup, roslyn to preview3-26411-06, preview3-26411-06, preview3-26411-06, beta4-62811-05, respectively consume bring your own shim(byos) (dotnet#9018) Fixing typos... Updating the dev-certs message displayed in the first run experience. Fix merge to only update core-setup and Roslyn versions. LOC CHECKIN | dotnet/cli master | 20180409 Add TryGetMostFitRuntimeIdentifier (dotnet#8997) Adapt to no config file Apphost shim Update CoreSetup, CoreSetup, CoreSetup, Roslyn to preview3-26406-06, preview3-26406-06, preview3-26406-06, beta4-62806-08, respectively Revert links on Readme to master Add test cases per PR feedback Tweak --no-build messages based on PR feedback Update CoreSetup, CoreSetup, CoreSetup, Roslyn to preview3-26405-02, preview3-26405-02, preview3-26405-02, beta4-62805-01, respectively Disabling msbuild node reuse for CLI full build. ... Conflicts: build/DependencyVersions.props
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The badge existence check was always returning false because the pattern match was not deterministic.
Paraphrased badge existence check logic:
StartsWith("linux_arm") && EndsWith(".svg")
Conflicting badge file names:
"linux_arm64_Release_version_badge.svg"
"linux_arm_Release_version_badge.svg"
The check was double verifying the linux_arm badge and always returning 'false' for the linux_arm64 badge.
Other:
FinishBuild.targets
'CheckIfAllBuildsHavePublished' target depends on the 'SetBadgeProps' target [VersionBadgeMoniker]
FinishBuild.targets
formatting...