This repository was archived by the owner on Jul 12, 2022. It is now read-only.
Disable the using location rule by default #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving a using from inside a namespace to outside it is a fundamentally dangerous operation. In part because it changes the context of the lookup: - Outside the namespace only the other usings are considered - Inside the namespace the namespace + the usings are considered This makes it trivial to create an error by moving a using directive around. Instead of continuing to patch this rule I've decided to just disable it by default for now. We can revisit and make it safer later on but for now it takes too much work to fix this.
Contributor
|
LGTM |
jaredpar
added a commit
that referenced
this pull request
Jul 8, 2015
Disable the using location rule by default
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving a using from inside a namespace to outside it is a fundamentally dangerous
operation. In part because it changes the context of the lookup:
This makes it trivial to create an error by moving a using directive around.
Instead of continuing to patch this rule I've decided to just disable it by
default for now. We can revisit and make it safer later on but for now it
takes too much work to fix this.