Merged
Conversation
Keboo
approved these changes
Apr 20, 2022
| var command = new RootCommand { argument }; | ||
|
|
||
| var parser = new CommandLineBuilder(command) | ||
| .UseTokenReplacer((string tokenToReplace, out IReadOnlyList<string> tokens, out string message) => |
Member
There was a problem hiding this comment.
Should this test also assert on the value of tokenToReplace? I assume in this situation it would be "@interpolate-me" or would it be "interpolate-me"?
Contributor
Author
There was a problem hiding this comment.
I'll add a test for this. The received tokenToReplace will not include the @. Open to changing that. My assumption was that this should be transparently removed, sort of like quotation marks.
Keboo
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the distinction between line-delimited and space-delimited response files, fixing #1665.
It does this by generalizing the mechanism where tokens prefixed with
@can be replaced with other tokens. Response files are one example of this but now alternative mechanisms can be introduced.