add source-build pre-built detection#2012
Merged
jonsequitur merged 2 commits intodotnet:mainfrom Jan 11, 2023
oleksandr-didyk:add-pre-built-detection
Merged
add source-build pre-built detection#2012jonsequitur merged 2 commits intodotnet:mainfrom oleksandr-didyk:add-pre-built-detection
jonsequitur merged 2 commits intodotnet:mainfrom
oleksandr-didyk:add-pre-built-detection
Conversation
27 tasks
eng/Version.Details.xml
Outdated
| <Sha>5a5ae41c42e475e280342b668e668ff34539e36d</Sha> | ||
| <SourceBuild RepoName="arcade" ManagedOnly="true" /> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="8.0.0-alpha.1.22616.1"> |
Member
There was a problem hiding this comment.
This should be a product dependency.
Contributor
Author
There was a problem hiding this comment.
Yeah, thanks for the reminder, will change
Contributor
Author
|
@jonsequitur I apologize for the ping, but it would be great if someone could review this small PR but there are no set reviewers on the repository. Let me know if I should address the review to someone else. Thank you |
jonsequitur
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2011
Additionally created a disabled subscription for the added dependency on source-build reference packages (will enable once this PR is merged):
CC: @MichaelSimons @crummel