Merged
Conversation
|
This seems wrong to me. Instead of looking at statically defined ancestry of the Command, it should get the CommandResult objects from the ParseResult in order to know which intermediate commands were actually used. I.e. if you have
and the user is asking for completions of "Mid2 Leaf", then it should offer only GlobalOption2 and not GlobalOption1. |
Member
Author
|
@KalleOlaviNiemitalo thank you for excellent feedback! I've added a failing test based on it and provided the fix. PTAL again |
jonsequitur
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every symbol can have multiple parents. When getting the completions for commands, the global options defined by the parent commands should be included as well. The problem was that we were searching only the parents of current command (flat, one level above), rather going up in the hierarchy to reach the root command
Discovered by dotnet/sdk#29131