Move BindingContext and related types to NamingConventionBinder project#2093
Merged
adamsitnik merged 8 commits intodotnet:mainfrom Mar 14, 2023
Merged
Move BindingContext and related types to NamingConventionBinder project#2093adamsitnik merged 8 commits intodotnet:mainfrom
adamsitnik merged 8 commits intodotnet:mainfrom
Conversation
…andLine, which exposes internals to S.CL.NCB
…lable only in S.CL.NCB
jonsequitur
approved these changes
Mar 14, 2023
This was referenced Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to remove
BindingContextfromInvocationContext(a step toward replacingInvocationContextwithParseResultin command handler/action), I've moved it to NamingConventionBinder and made the handler responsible for keeping the reference toBindingContext.Now all the
CommandHandler.Createmethods returnBindingHandlerrather thanICommandHandler, and to get theBindingContextthe users need to callInvocationContext.GetBindingContext(), which internaly usesctx.ParseResult.CommandResult.Command.Handler:Of course it's not that simple, I had to add some workarounds to adjust for the fact that Hosting uses Middleware for dependency injection registration and very late command handler creation.
I know that it ain't pretty, but the only alternative I had was removing
NamingConventionBinderproject.