Skip to content

remove TokenCompletionContext, make CompletionContext non-abstract#2126

Merged
adamsitnik merged 1 commit intodotnet:mainfrom
adamsitnik:CompletionContext
Mar 29, 2023
Merged

remove TokenCompletionContext, make CompletionContext non-abstract#2126
adamsitnik merged 1 commit intodotnet:mainfrom
adamsitnik:CompletionContext

Conversation

@adamsitnik
Copy link
Copy Markdown
Member

Explanation: TokenCompletionContext does not extend CompletionContext with any new API

fixes #1929

@adamsitnik adamsitnik requested a review from jonsequitur March 29, 2023 15:17
@adamsitnik adamsitnik enabled auto-merge (squash) March 29, 2023 15:28
@adamsitnik adamsitnik merged commit 7e84513 into dotnet:main Mar 29, 2023
@adamsitnik adamsitnik deleted the CompletionContext branch March 29, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider differentiating these two *CompletionContext scenarios using fewer public types

2 participants