Merged
Conversation
Keboo
approved these changes
Jun 7, 2023
adamsitnik
reviewed
Jun 8, 2023
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
Thank you for fixing the bug!
|
|
||
| if (validatedResult.Result == ArgumentConversionResultType.Successful | ||
| && convertedResult.Result == ArgumentConversionResultType.NoArgument) | ||
| if (validatedResult is { Result: ArgumentConversionResultType.Successful } |
Member
There was a problem hiding this comment.
do you find this syntax more readable?
Contributor
Author
There was a problem hiding this comment.
I prefer it as a best practice because the behavior of == can be changed by operator overloading.
| } | ||
| } | ||
| else if (argument.ValueType == typeof(bool) && | ||
| else if ((argument.ValueType == typeof(bool) || argument.ValueType == typeof(bool?)) && |
Member
There was a problem hiding this comment.
Great catch!
BTW a while ago I have introduced a helper method for that:
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing it out! I've updated to use that in my other PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2210. The issue was that
boolparsing had a special case in place so that it doesn't consume the following token if that token can't be parsed as a bool. This lets the unparseable token by consumed by a different symbol, which is typically the intent.The fix includes
bool?in that special case.