Skip to content

Use NetMinimum and NetFrameworkMinimum floating TFMs#2335

Closed
ViktorHofer wants to merge 10 commits into
mainfrom
UpdateTFMs
Closed

Use NetMinimum and NetFrameworkMinimum floating TFMs#2335
ViktorHofer wants to merge 10 commits into
mainfrom
UpdateTFMs

Conversation

@ViktorHofer
Copy link
Copy Markdown
Member

@ViktorHofer ViktorHofer commented Feb 23, 2024

  1. By using NetMinimum and NetFrameworkMinimum as the TFM properties, the command-line-api build will automatically target the minimum in-support version of .NET and .NET Framework.

  2. Upgrade the TFM to net8.0 as net7.0 is already out-of-support and Tactics (leadership) asked repositories to move away from net7.0 in the main branch (which targets the .NET 9 release in November 2024).

  3. Clean-up a few unnecessary msbuild properties and simplify items.

  4. Clean-up the #if NETX compiler preprocessor directives.

1. By using NetMinimum and NetFrameworkMinimum as the TFM properties,
  the command-line-api repository will automatically target the minimum
  in-support version of .NET and .NET Framework.

2. Upgrade the TFM to net8.0 as net7.0 will soon be out-of-support and
   Tactics (leadership) asked repositories to move away from net7.0
   already in the main branch.

3. Clean-up a few unnecessary msbuild properties and simplify items.

4. Clean-up the #if NETX compiler preprocessor directives.
@ViktorHofer
Copy link
Copy Markdown
Member Author

ViktorHofer commented Feb 23, 2024

So the ApprovalTests dependency update caused the baseline to be incorrect. I think this is due to a change in their implementation. Meaning, we will need to re-generate the baseline files as part of this PR.

Comment thread src/System.CommandLine.Tests/TestApps/NativeAOT/NativeAOT.csproj
@ViktorHofer ViktorHofer deleted the UpdateTFMs branch June 25, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants