Revert "Update ApprovalTests to 7.0.0 and revert workaround"#2610
Merged
adamsitnik merged 1 commit intomainfrom Jul 3, 2025
Merged
Revert "Update ApprovalTests to 7.0.0 and revert workaround"#2610adamsitnik merged 1 commit intomainfrom
adamsitnik merged 1 commit intomainfrom
Conversation
This reverts commit 3676a9e.
adamsitnik
approved these changes
Jul 3, 2025
Member
There was a problem hiding this comment.
LGTM, thank you @ViktorHofer !
FWIW the CancellableHandler_is_cancelled_on_process_termination is flaky, we can ignore the failure.
Edit: it seems I can no longer ignore test failures and merge on red ;)
ViktorHofer
added a commit
that referenced
this pull request
Jul 3, 2025
This reverts commit 6465818.
adamsitnik
pushed a commit
that referenced
this pull request
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3676a9e.