Do not sign dotnet-suggest when not building from the VMR#2677
Merged
mmitche merged 1 commit intodotnet:mainfrom Sep 29, 2025
Merged
Do not sign dotnet-suggest when not building from the VMR#2677mmitche merged 1 commit intodotnet:mainfrom
mmitche merged 1 commit intodotnet:mainfrom
Conversation
ViktorHofer
reviewed
Sep 29, 2025
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
@mmitche is this still needed?
Member
Author
|
Yes...this repo is on 9.0 arcade. |
Member
|
Is this also needed in release/10.0? Asking as I don't see the change there either. If so, you can change this PR's base branch to release/10.0 and the change will automatically flow forward (command-line-api now has an inter branch flow set up) or you can use the |
Member
Author
|
Changing the base requires a rebase, so i'll use backport |
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/command-line-api/actions/runs/18103858145 |
ViktorHofer
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.