Enable HostFxrMsi to install side by side between releases and build-to-build.#1571
Conversation
…on msi replaces the older version payload.
|
Hi @rakeshsinghranchi, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
| var inputDir = c.BuildContext.Get<string>("HostFxrPublishRoot"); | ||
| var wixObjRoot = Path.Combine(Dirs.Output, "obj", "wix", "hostfxr"); | ||
| var hostFxrBrandName = $"'{Monikers.GetHostFxrBrandName(c)}'"; | ||
| var upgradeCode = Utils.GenerateGuidFromName(HostFxrMsi).ToString().ToUpper(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@rakeshsinghranchi, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| var inputDir = c.BuildContext.Get<string>("HostFxrPublishRoot"); | ||
| var wixObjRoot = Path.Combine(Dirs.Output, "obj", "wix", "hostfxr"); | ||
| var hostFxrBrandName = $"'{Monikers.GetHostFxrBrandName(c)}'"; | ||
| var upgradeCode = Utils.GenerateGuidFromName(HostFxrMsi).ToString().ToUpper(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@jyoungyun do you know why Ubuntu Arm build failed here? |
|
@gkhanna79 Yes, I know. This issue is not related to this PR. Because we disabled the CI build in the Ubuntu ARM, the testResults files were not created, which would break the build. If the #1572 issue is merged, the build will be done normally and the result file will be created. |
| Cmd("powershell", "-NoProfile", "-NoLogo", | ||
| Path.Combine(Dirs.RepoRoot, "packaging", "windows", "hostfxr", "generatemsi.ps1"), | ||
| inputDir, HostFxrMsi, WixRoot, hostFxrBrandName, hostFxrMsiVersion, hostFxrNugetVersion, MSIBuildArch, TargetArch, wixObjRoot) | ||
| inputDir, HostFxrMsi, WixRoot, hostFxrBrandName, hostFxrMsiVersion, hostFxrNugetVersion, MSIBuildArch, TargetArch, wixObjRoot,upgradeCode) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| [Parameter(Mandatory=$true)][string]$TargetArchitecture, | ||
| [Parameter(Mandatory=$true)][string]$WixObjRoot | ||
| [Parameter(Mandatory=$true)][string]$WixObjRoot, | ||
| [Parameter(Mandatory=$true)][string]$HostFxrUpgradeCode |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| -dNugetVersion="$HostFxrNugetVersion" ` | ||
| -dComponentVersion="$ComponentVersion" ` | ||
| -dTargetArchitecture="$TargetArchitecture" ` | ||
| -dUpgradeCode="$HostFxrUpgradeCode" ` |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| var inputDir = c.BuildContext.Get<string>("HostFxrPublishRoot"); | ||
| var wixObjRoot = Path.Combine(Dirs.Output, "obj", "wix", "hostfxr"); | ||
| var hostFxrBrandName = $"'{Monikers.GetHostFxrBrandName(c)}'"; | ||
| var upgradeCode = Utils.GenerateGuidFromName(HostFxrMsi).ToString().ToUpper(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
6 participants
Enable HostFxrMsi to install side by side between releases and build-to-build. This fix is for 2.0 and will need similar fix for LTS branches.
Reference Issue:
https://github.com/dotnet/core-setup/issues/572