Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Custom deps feature implemented [IN PROGRESS].#1630

Closed
cakine wants to merge 1 commit intodotnet:masterfrom
cakine:custom_deps
Closed

Custom deps feature implemented [IN PROGRESS].#1630
cakine wants to merge 1 commit intodotnet:masterfrom
cakine:custom_deps

Conversation

@cakine
Copy link
Copy Markdown

@cakine cakine commented Mar 4, 2017

It's now possible to inject packages at runtime through custom .deps.json files. The files must be specified through DOTNET_CUSTOM_DEPS environment variable or through --custom-deps command line argument. It's important to notice that the command line argument overwrites the environment variable value.

For instance, if we wanted to load AppB during AppA execution:
dotnet --custom-deps ...\AppB.deps.json AppA.dll

It's possible to specify multiple files:
dotnet --custom-deps ...\AppB.deps.json;...\AppC.deps.json;...\AppD.deps.json AppA.dll

A directory path can be specified:
dotnet --custom-deps base_dir AppA.dll
Every .deps.json file contained in base_dir\shared\fx_name\fx_version will be picked.

It's also possible to mix directory and file paths:
dotnet --custom-deps base_dir1;...\AppB.deps.json;base_dir2 AppA.dll

The changes were manually tested, but it's still necessary to add unit tests to ensure that the new feature correctly follows the expected behavior.

Fixes dotnet/core-setup#1597

@dnfclas
Copy link
Copy Markdown

dnfclas commented Mar 4, 2017

@cakine,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@cakine
Copy link
Copy Markdown
Author

cakine commented Mar 4, 2017

@gkhanna79 @ramarag

@cakine cakine added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 4, 2017
@gkhanna79
Copy link
Copy Markdown
Member

Closing since this is now merged.

@gkhanna79 gkhanna79 closed this Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

* NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants