This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Custom deps feature implemented [IN PROGRESS].#1630
Closed
cakine wants to merge 1 commit intodotnet:masterfrom
Closed
Custom deps feature implemented [IN PROGRESS].#1630cakine wants to merge 1 commit intodotnet:masterfrom
cakine wants to merge 1 commit intodotnet:masterfrom
Conversation
|
@cakine, |
Author
Member
|
Closing since this is now merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's now possible to inject packages at runtime through custom .deps.json files. The files must be specified through DOTNET_CUSTOM_DEPS environment variable or through --custom-deps command line argument. It's important to notice that the command line argument overwrites the environment variable value.
For instance, if we wanted to load AppB during AppA execution:
dotnet --custom-deps ...\AppB.deps.json AppA.dll
It's possible to specify multiple files:
dotnet --custom-deps ...\AppB.deps.json;...\AppC.deps.json;...\AppD.deps.json AppA.dll
A directory path can be specified:
dotnet --custom-deps base_dir AppA.dll
Every .deps.json file contained in base_dir\shared\fx_name\fx_version will be picked.
It's also possible to mix directory and file paths:
dotnet --custom-deps base_dir1;...\AppB.deps.json;base_dir2 AppA.dll
The changes were manually tested, but it's still necessary to add unit tests to ensure that the new feature correctly follows the expected behavior.
Fixes dotnet/core-setup#1597