This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix the reading of host_interface_t to be backwards compatible.#1818
Merged
gkhanna79 merged 1 commit intodotnet:masterfrom Mar 23, 2017
AustinWise:fixBackwardsCompatOfHostInterfaceT
Merged
Fix the reading of host_interface_t to be backwards compatible.#1818gkhanna79 merged 1 commit intodotnet:masterfrom AustinWise:fixBackwardsCompatOfHostInterfaceT
gkhanna79 merged 1 commit intodotnet:masterfrom
AustinWise:fixBackwardsCompatOfHostInterfaceT
Conversation
PR #1727 added some new fields to host_interface_t but did not correctly check the size of the struct before reading the fields.
|
@AustinWise, |
Member
|
/cc @gkhanna79 |
gkhanna79
approved these changes
Mar 23, 2017
Member
gkhanna79
left a comment
gkhanna79
left a comment
There was a problem hiding this comment.
Good catch - thanks for fixing this!
Author
|
@gkhanna79 Not a problem, thanks for making this open source! It's fun to follow along and also I get some good ideas to improve code quality at work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1727 added some new fields to host_interface_t but did not correctly check the size of the struct before reading the fields.