This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Upgrade CLI, buildtools for RTM shared framework#246
Closed
dagood wants to merge 1 commit into
Closed
Conversation
| :: Restore dependencies mainly to obtain runtime.json | ||
| pushd "%__ProjectDir%\deps" | ||
| "%__ProjectDir%\Tools\dotnetcli\dotnet.exe" restore --source "https://dotnet.myget.org/F/dotnet-core" --packages "%__ProjectDir%\packages" | ||
| "%__DotNet%" restore --source "https://dotnet.myget.org/F/dotnet-core" --packages "%__ProjectDir%\packages" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
|
FYI @ramarag LGTM but I didn't dig into the CI failures which we should ensure works. |
Member
Author
|
CI failures are almost definitely the same as the ones in the corefx PR (dotnet/corefx#11387), caused by a change in the CLI package layout. I'll be updating the other repos' PRs when I get something working in corefx. |
Member
Author
|
Closing, these changes were made in #254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See dotnet/corefx#11387.
@weshaggard To make the upgrades work I changed
pack.cmd/shto use thedotnethost. Does that seem correct? No more corerun in the tools dir.Using RTM shared framework in buildtools means I should be able to follow up with a change to use the new version of
restore --disable-parallelismwhich also disables http parallel. This will help make the core-setup builds not so flaky./cc @yizhang82