Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Add Tizen 5.0 RID#4332

Merged
eerhardt merged 1 commit into
dotnet:masterfrom
gbalykov:add-tizen-5-rid
Jul 11, 2018
Merged

Add Tizen 5.0 RID#4332
eerhardt merged 1 commit into
dotnet:masterfrom
gbalykov:add-tizen-5-rid

Conversation

@gbalykov
Copy link
Copy Markdown
Member

@gbalykov gbalykov commented Jul 4, 2018

@eerhardt
Copy link
Copy Markdown
Member

eerhardt commented Jul 5, 2018

@dotnet-bot test this please

@@ -33,5 +33,8 @@
<UnofficialBuildRID Include="tizen.4.0.0-armel">

This comment was marked as spam.

This comment was marked as spam.

@eerhardt
Copy link
Copy Markdown
Member

eerhardt commented Jul 5, 2018

It doesn't appear that this fixed the Tizen leg. It is still failing.

The reason it is failing is because of errors like this:

Unable to find package transport.runtime.tizen.4.0.0-armel.Microsoft.NETCore.Runtime.CoreCLR with version (>= 3.0.0-preview1-26705-05)

Found 124 version(s) in https://tizen.myget.org/F/dotnet-core/api/v3/index.json [ Nearest version: 3.0.0-preview1-26624-03 ]

It looks like there hasn't been a runtime.tizen.4.0.0 build of coreclr in 2 weeks. Looking on https://tizen.myget.org/feed/dotnet-core/package/nuget/transport.runtime.tizen.4.0.0-armel.Microsoft.NETCore.Runtime.CoreCLR, I see the last version was built on Sun, 24 Jun 2018 12:49:12 GMT

@gbalykov
Copy link
Copy Markdown
Member Author

gbalykov commented Jul 5, 2018

@eerhardt we currently are unable to build nuget packages for tizen.5.0.0-armel as dotnet/corefx#30640 is not merged yet and some 2.1 packages, which are used during CoreFX build, do not contain Tizen 5.0 RID (one example is https://www.nuget.org/packages/Microsoft.NETCore.App/). So CI for both CoreFX and Core-Setup will be fixed only after the mentioned pull request is merged

@eerhardt
Copy link
Copy Markdown
Member

eerhardt commented Jul 5, 2018

From my understanding this failure has nothing to do with the tizen.5.0.0-armel RID. It is failing to find tizen.4.0.0-armel packages. Why aren't the 4.0 packages being built?

@gbalykov
Copy link
Copy Markdown
Member Author

gbalykov commented Jul 5, 2018

@eerhardt the problem is that CI build should depend only on tizen.5.0.0-armel, however, due to missing RIDs, tizen.4.0.0-armel dependency also appears. tizen.4.0.0-armel builds will be reenabled after tizen.5.0.0-armel build is fully fixed

@gbalykov
Copy link
Copy Markdown
Member Author

gbalykov commented Jul 5, 2018

@eerhardt actually, my last message considered #4246, as these pull requests are related

@gbalykov
Copy link
Copy Markdown
Member Author

@eerhardt could this be merged?
Related PR for CoreFX: dotnet/corefx#30875

@eerhardt
Copy link
Copy Markdown
Member

Yes, I can merge it. I'd like to get the Tizen leg green again. Do we know all the steps necessary to get it passing?

@eerhardt eerhardt merged commit a465d39 into dotnet:master Jul 11, 2018
@gbalykov
Copy link
Copy Markdown
Member Author

gbalykov commented Jul 17, 2018

@eerhardt, I have some problems during CoreFX/Core-Setup builds.

  1. I see next situation during release/2.1 build of CoreFX:

next files contain only tizen.4.0.0 RID references, and no tizen.5.0.0 references at all

./Tools/dotnetcli/shared/Microsoft.AspNetCore.All/2.1.0-rc1-final/Microsoft.AspNetCore.All.deps.json
./Tools/dotnetcli/shared/Microsoft.NETCore.App/2.1.0-rc1/Microsoft.NETCore.App.deps.json
./Tools/dotnetcli/shared/Microsoft.AspNetCore.App/2.1.0-rc1-final/Microsoft.AspNetCore.App.deps.json

./packages/microsoft.netcore.ilasm/2.1.3-servicing-26708-02/runtime.json
./packages/microsoft.netcore.dotnethostpolicy/2.1.3-servicing-26708-02/runtime.json
./packages/microsoft.netcore.dotnethost/2.1.3-servicing-26708-02/runtime.json
./packages/microsoft.netcore.runtime.coreclr/2.1.3-servicing-26708-02/runtime.json
./packages/microsoft.netcore.testhost/2.1.3-servicing-26708-02/runtime.json
./packages/microsoft.netcore.dotnethostresolver/2.1.3-servicing-26708-02/runtime.json
./packages/microsoft.netcore.dotnetapphost/2.1.3-servicing-26708-02/runtime.json
./packages/microsoft.netcore.app/2.1.0-rc1/runtime.json
./packages/microsoft.netcore.jit/2.1.3-servicing-26708-02/runtime.json

this leads to tizen.4.0.0 dependency, which is added to ./bin/obj/Unix.AnyCPU.Release/runtime/netcoreapp/Unix-armel/project.assets.json, and tizen.4.0.0 packages are used later.

  1. Besides, ./bin/obj/Unix.AnyCPU.Release/runtime/netcoreapp/Unix-armel/project.assets.json contains next
".NETCoreApp,Version=v2.1/tizen.5.0.0-armel": {
      "Microsoft.NETCore.DotNetAppHost/2.1.3-servicing-26708-02": {
        "type": "package",
        "dependencies": {
          "runtime.tizen.4.0.0-armel.Microsoft.NETCore.DotNetAppHost": "2.1.3-servicing-26708-02"
        }
      }

How could this circular dependency CoreFX (NETCoreApp) -> Core-Setup (DotNetAppHost) -> CoreFX (NETCoreApp) be handled, when there are no nuget packages for new RID (tizen.5.0.0) yet?

@eerhardt
Copy link
Copy Markdown
Member

@gbalykov - we just got a new 2.1.3 servicing build of core-setup out yesterday: 2.1.3-servicing-26718-02. I verified that the Microsoft.NETCore.DotNetAppHost runtime.json contains a reference to

    "tizen.5.0.0-armel": {
      "Microsoft.NETCore.DotNetAppHost": {
        "runtime.tizen.5.0.0-armel.Microsoft.NETCore.DotNetAppHost": "2.1.3-servicing-26718-02"
      }
    },

So you should be able to move up to that version and build again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants