Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Update Microsoft.NETCore.App to target netcoreapp1.1#464

Merged
weshaggard merged 2 commits into
dotnet:release/1.1.0from
weshaggard:UpdateNetcoreAppToVersion1.1
Oct 25, 2016
Merged

Update Microsoft.NETCore.App to target netcoreapp1.1#464
weshaggard merged 2 commits into
dotnet:release/1.1.0from
weshaggard:UpdateNetcoreAppToVersion1.1

Conversation

@weshaggard
Copy link
Copy Markdown
Member

Fix https://github.com/dotnet/core-setup/issues/456

cc @ericstj @gkhanna79

Right now the test projects in this branch are still using netcoreapp1.0 as the target framework. I'm still debating whether or not to try and update those to netcoreapp1.1 like I'm doing in master with #462. What do you guys think?

@weshaggard
Copy link
Copy Markdown
Member Author

looks like I'm going to need to update the test projects (not sure why this didn't fail locally for me)

   One or more packages are incompatible with .NETCoreApp,Version=v1.0 (ubuntu.16.10-x64).

because they have the new RIDs are only supported in netcoreapp1.1 packages but they have these new runtimes. @mellinoe do you think we should split the tests (i.e. one with the new RIDS targeting netcoreapp1.1 and one without the new RIDS targeting netcoreapp1.0) or should we just bump things to 1.1. I'm leaning towards just bumping them to 1.1 but I'm curious to see what others think.

@mellinoe
Copy link
Copy Markdown

mellinoe commented Oct 20, 2016

I initially had tried retargeting all the tests netcoreapp1.1, but hit some other failures. I believe that some of the tests are hardcoded to assume that "netcoreapp1.0" is the one and only TFM for the tests, so you might end up hitting a couple of errors like that. But yeah, we will need to retarget the tests to netcoreapp1.1.

@gkhanna79
Copy link
Copy Markdown
Member

I concur with bumping the version.


<!--
Manually include the netcoreapp1.0 dependencies.
If any versions change in the release/1.0.0 branch they should

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@weshaggard
Copy link
Copy Markdown
Member Author

@gkhanna79 please go ahead and merge this when release/1.1.0 is ready to take changes.

@mellinoe
Copy link
Copy Markdown

Since the Jenkins change isn't in yet (#466), have you been able to see if this works on Ubuntu 16.10 / openSUSE 42.1?

@weshaggard
Copy link
Copy Markdown
Member Author

Since the Jenkins change isn't in yet (#466), have you been able to see if this works on Ubuntu 16.10 / openSUSE 42.1?

No but for this 1.1 change I didn't need to update the CLI, that is only part of the master PR. So my expectation is that this shouldn't be an issue.

@weshaggard weshaggard merged commit 06094c8 into dotnet:release/1.1.0 Oct 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants