Update Microsoft.NETCore.App to target netcoreapp1.1#464
Conversation
|
looks like I'm going to need to update the test projects (not sure why this didn't fail locally for me) because they have the new RIDs are only supported in netcoreapp1.1 packages but they have these new runtimes. @mellinoe do you think we should split the tests (i.e. one with the new RIDS targeting netcoreapp1.1 and one without the new RIDS targeting netcoreapp1.0) or should we just bump things to 1.1. I'm leaning towards just bumping them to 1.1 but I'm curious to see what others think. |
|
I initially had tried retargeting all the tests netcoreapp1.1, but hit some other failures. I believe that some of the tests are hardcoded to assume that "netcoreapp1.0" is the one and only TFM for the tests, so you might end up hitting a couple of errors like that. But yeah, we will need to retarget the tests to |
|
I concur with bumping the version. |
|
|
||
| <!-- | ||
| Manually include the netcoreapp1.0 dependencies. | ||
| If any versions change in the release/1.0.0 branch they should |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@gkhanna79 please go ahead and merge this when release/1.1.0 is ready to take changes. |
|
Since the Jenkins change isn't in yet (#466), have you been able to see if this works on Ubuntu 16.10 / openSUSE 42.1? |
No but for this 1.1 change I didn't need to update the CLI, that is only part of the master PR. So my expectation is that this shouldn't be an issue. |
Fix https://github.com/dotnet/core-setup/issues/456
cc @ericstj @gkhanna79
Right now the test projects in this branch are still using netcoreapp1.0 as the target framework. I'm still debating whether or not to try and update those to netcoreapp1.1 like I'm doing in master with #462. What do you guys think?