Enable WinArm32 build#465
Conversation
ianhays
left a comment
There was a problem hiding this comment.
I don't see anything that stands out as negative here. The changes to TestTargets.cs seem unnecessary as you can avoid tests by just not passing that target when you build, but they shouldn't cause issues. All in all this LGTM.
|
Blocked on #462. CC @weshaggard |
|
LGTM - What is blocking this? |
|
@weshaggard The failures like the one below are the ones you are working to get fixed in your PR:
Once your PR merges, I will rebase against it to ensure this is green and then merge. |
|
Ah yes. that is triggered by you taking the newer CoreCLR package which isn't backwards compatible with 1.0. We are currently blocked on getting an updated CLI to fix this correctly. |
|
Closing in favor of #526 |
This change enables building Core-Setup for WinArm32.
@schellap @ianhays PTAL