Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Enable WinArm32 build#465

Closed
gkhanna79 wants to merge 2 commits into
dotnet:masterfrom
gkhanna79:Arm32Build
Closed

Enable WinArm32 build#465
gkhanna79 wants to merge 2 commits into
dotnet:masterfrom
gkhanna79:Arm32Build

Conversation

@gkhanna79
Copy link
Copy Markdown
Member

This change enables building Core-Setup for WinArm32.

@schellap @ianhays PTAL

Copy link
Copy Markdown

@ianhays ianhays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything that stands out as negative here. The changes to TestTargets.cs seem unnecessary as you can avoid tests by just not passing that target when you build, but they shouldn't cause issues. All in all this LGTM.

@gkhanna79 gkhanna79 added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 20, 2016
@gkhanna79
Copy link
Copy Markdown
Member Author

Blocked on #462.

CC @weshaggard

@weshaggard
Copy link
Copy Markdown
Member

LGTM - What is blocking this?

@gkhanna79
Copy link
Copy Markdown
Member Author

@weshaggard The failures like the one below are the ones you are working to get fixed in your PR:

x64/tests/artifacts/2/StandaloneApp/bin/StandaloneApp Arguments: Exit Code: 134 StdOut: StdErr: Unhandled Exception: System.TypeLoadException: Could not load type 'System.IO.TextWriter' from assembly 'System.IO, Version=4.1.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. at System.Console.WriteLine(String value) at StandaloneApp.Program.Main(String[] args)

Once your PR merges, I will rebase against it to ensure this is green and then merge.

@weshaggard
Copy link
Copy Markdown
Member

Ah yes. that is triggered by you taking the newer CoreCLR package which isn't backwards compatible with 1.0. We are currently blocked on getting an updated CLI to fix this correctly.

@gkhanna79
Copy link
Copy Markdown
Member Author

Closing in favor of #526

@gkhanna79 gkhanna79 closed this Oct 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

* NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants