Fixes to build against NETCoreApp1.1.#524
Conversation
This allows for folks to build the packages without doing a full repo build after they have built the full repo at least once they can now just call pack.cmd/sh.
Split the dependencies in Microsoft.NETCore.App based on 1.0 and 1.1. We also needed to update some tests to be netcoreapp1.1 targeting now
|
@weshaggard @dagood @mellinoe We have a green CI with changes from @weshaggard and my fixes for lower-case fixes. @mellinoe Do you need to perform any validations for the CLI for the new distros? |
|
|
||
| DOTNET_INSTALL_SCRIPT_URL="https://raw.githubusercontent.com/dotnet/cli/rel/1.0.0/scripts/obtain/dotnet-install.sh" | ||
| curl -sSL "$DOTNET_INSTALL_SCRIPT_URL" | bash /dev/stdin --version 1.0.0-preview3-003223-3 --verbose | ||
| curl -sSL "$DOTNET_INSTALL_SCRIPT_URL" | bash /dev/stdin --version 1.0.0-preview3-003886 --verbose |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The CI is turned on for Ubuntu 16.10 and openSUSE 42.1, and Fedora 24 isn't actually ported over to master yet. I'm working on that now and will make sure that it works with this change (I need to upload a version to azure for it). |
|
In that case, any concerns if I go ahead and merge this change @weshaggard ? |
|
@mellinoe did you upload the manually created CLI for the new distro's? Otherwise I don't know how they are passing in CI. |
|
Merging on behalf @weshaggard for netcoreapp1.1 changes, alongwith my fixes to handle lower-case nuget restores. |
5 participants
CC @weshaggard