This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Allow getting contract for previously initialized hostpolicy#6343
Merged
Conversation
This enables getting runtime properties for the active context created through non-context-based entry points.
vitek-karas
approved these changes
May 7, 2019
| int rc = hostpolicy_contract.initialize(nullptr, intialization_options_t::get_contract, &hostpolicy_context_contract); | ||
| if (rc != StatusCode::Success) | ||
| { | ||
| trace::warning(_X("Failed to get contract for existing initialized hostpolicy: 0x%x"), rc); |
Member
There was a problem hiding this comment.
I would prefer to fail here. I understand we can make it work, but I think it's dangerous to ignore any failure from hostpolicy. I can't think of a scenario where having this would be important, so unless we can come up with one, I would prefer we block this branch for now. We can always reenable it later on.
Co-Authored-By: elinor-fung <47805090+elinor-fung@users.noreply.github.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…core-setup#6343) This enables getting runtime properties for the active context created through non-context-based entry points. Commit migrated from dotnet/core-setup@5c4ca8a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables getting runtime properties for the active context created
through non-context-based entry points.
Fixes #6197