This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Stop signing apphost.exe and comhost.dll in nupkg#7547
Merged
dagood merged 2 commits intodotnet:masterfrom Aug 2, 2019
Merged
Conversation
It shouldn't be limited to binaries signing stage. It needs to be active during SignFinalPackages, but it might as well be set during any signing to match intent.
vitek-karas
approved these changes
Aug 2, 2019
Member
vitek-karas
left a comment
vitek-karas
left a comment
There was a problem hiding this comment.
We will need to port this to release/3.0 and probably communicate this broadly - as it's broken in P8.
Member
Author
|
What breaks when these files are signed? Could you maybe file a issue with details to start with? (I'm happy to create the port PR to 3.0.) |
Member
Author
|
I'm going to go ahead and merge: this has no affect on PR validation builds, and I want to see it in action in an official build. |
Member
|
@elinor-fung can you please file the issue - since you played with it in detail. The broken scenario is: Build an app with app.exe - try to sign the app.exe with my own cert - fails. |
dagood
commented
Aug 2, 2019
This was referenced Aug 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nupkg is recursively signed, so leaving
apphost.exeandcomhost.dlloff the list of files to sign is not enough, and they still end up signed. We also need to set upFileSignInfoto tell recursive signing what to do.