This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Do not add x86 host to PATH on 64-bit machines#9212
Merged
NikolaMilosavljevic merged 1 commit intoJun 13, 2022
Merged
Conversation
NikolaMilosavljevic
changed the title
|
Needs the |
Member
Author
Thanks. Yeah, I know. I was waiting on some testing to be completed before adding reviewers, tags and sending to Tactics. |
NikolaMilosavljevic
added
area-Setup
Servicing-consider
Member
Author
NikolaMilosavljevic
added
Servicing-approved
joeloff
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of dotnet/runtime#69902 to dotnet/core-setup release/3.1
Fixes: dotnet/runtime#70039
Customer Impact
This fixes the remaining issue with non-native host paths in machine's environment (PATH).
The fix uses a different model than x64-on-arm64. It is a simpler change as it's easy to determine if machine is 64-bit, using WersionNT64 property. This solution avoids unnecessary changes in arcade infra and adding additional complexity.
Testing
See main issue: dotnet/runtime#70039 (comment)
Risk
As with any breaking change, this will affect some users. In this case, anyone that wants 32-bit host (dotnet.exe) to be in PATH on 64-bit machines, will need to add host location to PATH manually.