Lookup System.Runtime and mscorlib references by Assembly name

[mletterle]

Rather than by alias.

Fixes #10595

[dnfclas]

@mletterle,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

[dnfclas]

@mletterle, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

[dnfclas]

@mletterle, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

[danmoseley]

@dotnet/jit-contrib do you guys own ilasm?

[danmoseley]

@dotnet-bot test OSX10.12 x64 Checked Build and Test (network)

[danmoseley]

@dotnet-bot test Ubuntu x64 Checked Build and Test (log gone)

[danmoseley]

@dotnet/jit-contrib could you please evaluate this.

[RussKeldorph]

@mletterle Apologies (again) for missing this PR. If you're happy with where #10878 is going, could you close this one? Thank you very much for helping make ilasm better. In the future, feel free to mention me directly on any ilasm/ildasm/jit-related issues or PRs so hopefully I don't miss them.

[mletterle]

@RussKeldorph While the two PRs do solve the same problem, the code they contain is pretty orthogonal, my PR changes the way BaseAsmRef is determined which will affect how it is determined wherever that call is used. Which may fix other unreferenced issues. Though there is probably a discussion to be had on the whole "BaseAsmRef" idea in general.

Thanks for helping address these long standing issues! Exciting times in cil land...

[rartemev]

@dotnet-bot test Ubuntu x64 Checked Build and Test please

[rartemev]

@mletterle As I can see you changes solve the original issue but still cannot handle chained aliases like test from my PR does.

[mletterle]

This PR is specifically to avoid aliases all together and look at the simple name of the Assembly to determine if it is System.Runtime for example.

Also I don't believe it's possible to define an alias that refers to another alias.

Partition II § 6.3 doesn't appear to provide a mechanism for that since it says:

The dotted name used in .assembly extern shall exactly match the name of the assembly as declared
with an .assembly directive, in a case-sensitive manner

emphasis mine.

[rartemev]

@dotnet-bot test Ubuntu16.04 arm Cross Debug Build
@dotnet-bot test OSX10.12 x64 Checked Build and Test
@dotnet-bot test Ubuntu arm Cross Release Build

[rartemev]

Since all CI tests have passed it looks good to me. Besides that I am still not sure about alias chains so I'd rather ask @RussKeldorph to clarify this question.

[RussKeldorph]

@mletterle Thanks!