This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Correctly unwind esp frames#10685
Merged
Merged
Conversation
Author
|
@dotnet-bot test OSX10.12 x64 Checked Build and Test please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnwindEspFrame already considers pushed argument size when unwinding esp frame, and thus SP should be current SP (not SP before argument pushes) when invoking UnwindEspFrame.
Unfortunately, OOPStackUnwinderX86::VirtualUnwind provides SP before argument pushes, which results in incorrect unwinding inside baseservices.threading.monitor.enter.monitorenter.
This commit revises x86/Linux unwider to correctly unwind esp frames.