Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Skip failing tests in Helix #11085

Merged
wtgodbe merged 1 commit into from
Apr 19, 2017
Merged

Skip failing tests in Helix #11085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@

<!-- The following are tests that fail on non-Windows, which we must not run when building against packages -->

<ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(BuildTestsAgainstPackages)' == 'true' and '$(RuntimeID)' != ''">
<ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(BuildTestsAgainstPackages)' == 'true' and '$(TargetsWindows)' != 'true'">
Copy link
Copy Markdown
Member

@gkhanna79 gkhanna79 Apr 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we never specified RuntimeID?

Copy link
Copy Markdown
Member Author

@wtgodbe wtgodbe Apr 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do specify RuntimeID, it's just not available here anymore. Previously, if a runtimeID was passed, that meant we were building tests for non-windows; now we always pass a runtimeID when building against packages, and have an explicit variable (TargetsWindows) that determines if we're building tests for Windows or non-Windows - I just missed updating this file when I made that change.

<ExcludeList Include="$(XunitTestBinBase)\CoreMangLib\cti\system\byte\ByteToString3\ByteToString3.cmd">
<Issue>needs triage</Issue>
</ExcludeList>
Expand Down