This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[Preview] Undo VM portion of #9789#11208
Merged
Merged
Conversation
Maintain compat with JIT32 for 2.0 Preview
Author
|
Another option is to port #9789 to JIT32, but I prefer this option for Preview unless we know of a reason it wouldn't work. /cc @dotnet/jit-contrib |
RussKeldorph
changed the title
|
Seems okay to me. |
BruceForstall
approved these changes
Apr 25, 2017
briansull
approved these changes
Apr 25, 2017
mikedn
approved these changes
Apr 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintain compat with JIT32 for 2.0 Preview. #9789 introduced a performance optimization involving a change to the JIT and JIT interface. Since this optimization was not added to JIT32, we should disable it for Preview, returning behavior to that prior to #9789 for Preview. Since JIT32 is being removed post-Preview, this change does not need to go into master.
Fixes #11088.