This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Refactor emitter::emitInsMov#12905
Merged
Merged
Conversation
None of this function's callers need it to figure out what kind of "mov" to emit, the callers already know what they need and they should call the appropiate function. Copy & paste code, no actual changes.
This way it can be used for contained indirs where the destination register is set on the parent node.
Author
|
Extracted from #12676 to keep that one focused on cast issue(s). No diffs. First commit is best viewed with "ignore white space changes" - 528b1fa?w=1 |
|
@dotnet/jit-contrib PTAL |
BruceForstall
approved these changes
Aug 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of this function's callers need it to figure out what kind of "mov" to emit, the callers already know what they need and they should call the appropriate function.