Add Intel hardware intrinsic API implementation to mscorlib#13576
Conversation
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
| // ------------------------------------------------------------------------------ | ||
| // Changes to this file must follow the http://aka.ms/api-review process. |
There was a problem hiding this comment.
This comment does not apply here.
| /// <summary> | ||
| /// This class provides access to Intel AES hardware instructions via intrinsics | ||
| /// </summary> | ||
|
|
| { | ||
| public static bool IsSupported {get;} | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Nit: Add new lines at the end of the file
| [StructLayout(LayoutKind.Sequential, Size = 32)] | ||
| public struct Vector256<T> where T : struct | ||
| { | ||
| public static bool IsSupported {get;} |
There was a problem hiding this comment.
The IsSupported properties should return false. (And the intrinsic JIT implementation should override it to return true.)
fiigii
force-pushed
the
intelintrinsic
branch
3 times, most recently
from
627ed78 to
8e6acef
Compare
|
Change build condition to AnyCPU for leaving these intrinsics as stubs on other platforms. Successfully build with CoreFX change. @jkotas PTAL. |
fiigii
force-pushed
the
intelintrinsic
branch
from
8e6acef to
a99c881
Compare
UpdateSeparate SSE intrinsics from |
fiigii
force-pushed
the
intelintrinsic
branch
from
a99c881 to
179cda9
Compare
|
@jkotas I have addressed all the feedback and rebased to solve conflicts. Could you please take a look? |
|
LGTM |
|
@dotnet-bot test OSX10.12 x64 Checked Build and Test |
|
@dotnet-bot test OSX10.12 x64 Checked Build and Test |
|
@jkotas Could you please merge this PR? Then we can test and build the CoreFX counterpart in the CI system. |
5 participants
This PR is the complete design of API Proposal: Add Intel hardware intrinsic functions and namespace #22940 and the mscorlib counterpart of Add Intel hardware intrinsic APIs to CoreFX #23489.
For building with the current code base,
constparameter modifiers and[intrinsic]is temporarily removed.