This repository was archived by the owner on Jan 23, 2023. It is now read-only.
JIT: optimize case where box feeds GetType#13710
Merged
AndyAyersMS merged 2 commits intoSep 12, 2017
Merged
Conversation
Member
Author
|
@JosephTremoulet PTAL Jit-diffs results |
JosephTremoulet
approved these changes
Aug 31, 2017
JosephTremoulet
left a comment
JosephTremoulet
left a comment
There was a problem hiding this comment.
Looks good. I'm curious why not do the same for non-box trees that we can find an exact type for and know are non-null... what are the relative costs of GetType() and TypeHandleToRuntimeType()? Also, would doing the rewrite potentially open further optimizations (like if we go on to compare the type...)?
Member
Author
|
The one test failure looks like a legitimate issue with this change. In shared contexts the class handle may be a representative type and not the exact type. In other words we end up creating instead of So this needs some revision; likely we need to repurpose the handle that is passed to the newobj helper instead of trying to create one from scratch. |
Member
Author
|
Will rework this once #13748 is in. |
If the only use of a box is in a call to Type:GetType, remove the box and obtain the type directly. Get the handle needed for obtaining the type from the newobj call in the original box, via a new box removal option. Also add some logging to the type optimizations done in morph. Closes #13187.
AndyAyersMS
force-pushed
the
UpdateTypeEqualityOptimization
branch
from
e61f846 to
2e78bfc
Compare
Member
Author
|
Reworked this a fair amount.... jit-diffs very similar to the above, but should avoid the bug in the earlier version. |
Member
Author
|
Windows x64 debug timed out in tailcall_v4/hijack. It passes locally, so will retry. @dotnet-bot retest Windows_NT x64 Debug Build and Test |
Member
Author
|
Ah, I don't need the changes in value numbering any more. No point introducing dead code. Let me snip that bit out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the only use of a box is in a call to Type:GetType, we can remove the
box and just construct the type directly.
Also add some logging to the type optimizations done in morph.
Closes #13187.