Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Enable EventPipe and EventSource Functional Tests #15917

Merged
brianrob merged 3 commits into from
Jan 18, 2018
Merged

Enable EventPipe and EventSource Functional Tests #15917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17ddea3
Unconditionally include EventPipe.cs on all platforms.
brianrob Jan 16, 2018
e642268
Enable EventSource and EventPipe functional tests.
brianrob Jan 16, 2018
9e25023
Disable tests based on feedback.
brianrob Jan 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mscorlib/System.Private.CoreLib.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@
<Compile Include="$(BclSourcesRoot)\System\Diagnostics\Eventing\EventSource_CoreCLR.cs" />
<Compile Condition="'$(FeatureXplatEventSource)' == 'true'" Include="$(BclSourcesRoot)\System\Diagnostics\Eventing\XplatEventLogger.cs" />
<Compile Include="$(BclSourcesRoot)\System\Diagnostics\Eventing\FrameworkEventSource.cs" />
<Compile Condition="'$(FeaturePerfTracing)' == 'true'" Include="$(BclSourcesRoot)\System\Diagnostics\Eventing\EventPipe.cs" />
<Compile Include="$(BclSourcesRoot)\System\Diagnostics\Eventing\EventPipe.cs" />
<Compile Condition="'$(FeaturePerfTracing)' == 'true'" Include="$(BclSourcesRoot)\System\Diagnostics\Eventing\EventPipeEventProvider.cs" />
</ItemGroup>
<ItemGroup>
Expand Down
11 changes: 11 additions & 0 deletions tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1726,6 +1726,17 @@
<ExcludeList Include="$(XunitTestBinBase)\managed\Compilation\Compilation\Compilation.cmd">
<Issue>needs triage</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)\tracing\eventsourcetrace\*">
<Issue>15919</Issue>
</ExcludeList>
</ItemGroup>

<!-- The following are tests that fail on Windows -->

<ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(TargetsWindows)' == 'true'">
<ExcludeList Include="$(XunitTestBinBase)\tracing\eventsource*">
<Issue>15494</Issue>
</ExcludeList>
</ItemGroup>

<!-- Failures while testing via ILLINK -->
Expand Down
2 changes: 0 additions & 2 deletions tests/src/dirs.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
<DisabledProjects Include="Performance\performance.csproj" />
<DisabledProjects Include="Loader\classloader\generics\regressions\DD117522\Test.csproj" />
<DisabledProjects Include="Loader\classloader\generics\GenericMethods\VSW491668.csproj" /> <!-- issue 5501 -->
<DisabledProjects Include="tracing\eventsource*\*.csproj" />
<DisabledProjects Include="tracing\eventpipe*\*.csproj" />
</ItemGroup>

<ItemGroup>
Expand Down