Revert "Add environment variable (COMPlus_EnableDiagnostics) to disab… by RussKeldorph · Pull Request #16007 · dotnet/coreclr

RussKeldorph · 2018-01-25T00:56:54Z

…le debugging and profiling. (#15878)"

This reverts commit 5bcfde4.

If the armel CI jobs don't hang on this, then that suggests #15878 is responsible for #15914.

…le debugging and profiling. (#15878)" This reverts commit 5bcfde4.

jkotas · 2018-01-25T06:40:48Z


        RaiseStartupNotification();

+        // Also initialize the AppDomainEnumerationIPCBlock


@mikem8361 Notice that FEATURE_DBGIPC_TRANSPORT_VM block above uses m_pAppDomainCB - that is initialized too late now.

My change that is being reverted moved the m_pAppDomainCB initialization to almost the beginning of Debugger::Startup() so it should be initialized.

The change is moving the m_AppDomainCB back to where it was (later in Startup()).

Am I missing something?

Sorry, I go it backward ... you are right. But I do think that the change of the order here caused the regression somehow.

And it is likely that we have the same regression on other Linux flavors and just do not see it as often. The ARM emulator is a lot slower than a real machine, so it hits races that are hard to hit elsewhere.

benaadams · 2018-01-25T09:11:19Z

Sort of worked; but not reporting success to CI

Perform an action if the job was performed on an Azure VM Agent. is waiting for a checkpoint on 
dotnet_coreclr » master » armel_cross_checked_tizen_prtest #2999
[Current build status] check if current [SUCCESS] is worse or equals then [SUCCESS] and better or equals then [SUCCESS]
Run condition [Current build status] enabling perform for step [[Archive the artifacts]]
Archiving artifacts
Notifying endpoint with credentials id 'helix-int-notification-url'
Notifying endpoint with credentials id 'helix-prod-notification-url'
Setting status of 8e42b4cdba2607956477336d6bc3ac2aa0cd57c4 to SUCCESS with url https://ci.dot.net/job/dotnet_coreclr/job/master/job/armel_cross_checked_tizen_prtest/3000/ and message: 'Build finished. '
Using context: Tizen armel Cross Checked Build
[WS-CLEANUP] Deleting project workspace...Cannot delete workspace
 :remote file operation failed:
 /mnt/j/workspace/dotnet_coreclr/master/armel_cross_checked_tizen_prtest at hudson.remoting.Channel@6e0ba86f:ubuntu1404-20170120-9d4ad3:
 java.io.IOException: Unable to delete '/mnt/j/workspace/dotnet_coreclr/master/armel_cross_checked_tizen_prtest/Tools/15.0/Microsoft.Common.props'.
 Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.
ERROR: Step ‘Delete workspace when build is done’ failed:
 Cannot delete workspace:
 remote file operation failed:
 /mnt/j/workspace/dotnet_coreclr/master/armel_cross_checked_tizen_prtest at hudson.remoting.Channel@6e0ba86f:ubuntu1404-20170120-9d4ad3:
 java.io.IOException: Unable to delete '/mnt/j/workspace/dotnet_coreclr/master/armel_cross_checked_tizen_prtest/Tools/15.0/Microsoft.Common.props'.
 Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.
Finished: SUCCESS

mikem8361 · 2018-01-25T14:59:48Z

The error you hit seems to be a build infrastructure problem.

I really hope we won't have to merge this reversion. I don't see how this could affect only Linux Arm tests. I don't know how to debug this environment .

benaadams · 2018-01-25T15:00:33Z

CentOS7.1 x64 Release Innerloop Build and Test seems infrastructure

First time build. Skipping changelog.
parallel {
    Schedule job dotnet_coreclr » master » x64_release_centos7.1_innerloop_prtest
    Build dotnet_coreclr » master » x64_release_centos7.1_innerloop_prtest #12 started
    dotnet_coreclr » master » x64_release_centos7.1_innerloop_prtest #12 completed 
ERROR: Failed to run DSL Script
java.util.concurrent.ExecutionException:
dbees.plugins.flow.JobNotFoundException:
net_coreclr/master/x64_release_windows_nt_innerloop_bld_prtest not found (or isn't a job).
	at java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.util.concurrent.FutureTask.get(FutureTask.java:192)
	at java_util_concurrent_Future$get.call(Unknown Source)
	at com.cloudbees.plugins.flow.FlowDelegate$_parallel_closure6.doCall(FlowDSL.groovy:456)
	at sun.reflect.GeneratedMethodAccessor1199.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
	at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
	at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1022)
	at groovy.lang.Closure.call(Closure.java:414)
	at groovy.lang.Closure.call(Closure.java:430)

mikem8361 · 2018-01-25T15:09:34Z

Another infrastructure problem.

…

-------- Original message -------- From: Ben Adams <notifications@github.com> Date: 1/25/18 7:01 AM (GMT-08:00) To: dotnet/coreclr <coreclr@noreply.github.com> Cc: Mike McLaughlin <mikem@microsoft.com>, Mention <mention@noreply.github.com> Subject: Re: [dotnet/coreclr] [WIP] Revert "Add environment variable (COMPlus_EnableDiagnostics) to disab… (#16007) CentOS7.1 x64 Release Innerloop Build and Test seems infrastructure First time build. Skipping changelog. parallel { Schedule job dotnet_coreclr » master » x64_release_centos7.1_innerloop_prtest Build dotnet_coreclr » master » x64_release_centos7.1_innerloop_prtest #12 started dotnet_coreclr » master » x64_release_centos7.1_innerloop_prtest #12 completed ERROR: Failed to run DSL Script java.util.concurrent.ExecutionException: dbees.plugins.flow.JobNotFoundException: net_coreclr/master/x64_release_windows_nt_innerloop_bld_prtest not found (or isn't a job). at java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.util.concurrent.FutureTask.get(FutureTask.java:192) at java_util_concurrent_Future$get.call(Unknown Source) at com.cloudbees.plugins.flow.FlowDelegate$_parallel_closure6.doCall(FlowDSL.groovy:456) at sun.reflect.GeneratedMethodAccessor1199.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93) at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325) at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294) at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1022) at groovy.lang.Closure.call(Closure.java:414) at groovy.lang.Closure.call(Closure.java:430) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fcoreclr%2Fpull%2F16007%23issuecomment-360491512&data=02%7C01%7Cmikem%40microsoft.com%7C6795908e93424e10711908d5640475f9%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636524892675215453&sdata=RqFXbJcZSFNnbI5lBipuUt8U170MZpOrygQxLnhGdPU%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJ-Fa2NQM5U6jHBr4Dz1Qohu3HFMQxtGks5tOJcxgaJpZM4RsK0w&data=02%7C01%7Cmikem%40microsoft.com%7C6795908e93424e10711908d5640475f9%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636524892675215453&sdata=0QVbXG3oMCfybibx8e%2BMKgANLnlF5Qz9VXHM7H5pOkE%3D&reserved=0>.

jkotas · 2018-01-25T15:26:10Z

I don't see how this could affect only Linux Arm tests.

There is a strong evidence that it did affect Linux Arm tests. They started consistently failing right after your change went in; and this trial revert made them pass again.

RussKeldorph · 2018-01-25T16:41:20Z

I really hope we won't have to merge this reversion. I don't see how this could affect only Linux Arm tests. I don't know how to debug this environment .

@mikem8361 I'm not insisting that merging this is the right fix. I just wanted to demonstrate that #15878 is the likely culprit. I think @jashook or @Samsung can help get you set up to debug in this environment if you can't figure it out with @jkotas thoughts. I would ask that you make it your top priority to investigate this and consider merging this PR if you can't, however.

mikem8361 · 2018-01-25T16:51:43Z

I'm on vacation until Monday so you probably want to merge this.

…

-------- Original message -------- From: Russ Keldorph <notifications@github.com> Date: 1/25/18 8:41 AM (GMT-08:00) To: dotnet/coreclr <coreclr@noreply.github.com> Cc: Mike McLaughlin <mikem@microsoft.com>, Mention <mention@noreply.github.com> Subject: Re: [dotnet/coreclr] [WIP] Revert "Add environment variable (COMPlus_EnableDiagnostics) to disab… (#16007) I really hope we won't have to merge this reversion. I don't see how this could affect only Linux Arm tests. I don't know how to debug this environment . @mikem8361<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmikem8361&data=02%7C01%7Cmikem%40microsoft.com%7Cb576e1d04d3b41a34dfe08d564128616%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636524953072637724&sdata=aEWqr%2BM4az7l47rLuOpPev5FZlO7qqaqG8BImz5C6l0%3D&reserved=0> I'm not insisting that merging this is the right fix. I just wanted to demonstrate that #15878<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fcoreclr%2Fpull%2F15878&data=02%7C01%7Cmikem%40microsoft.com%7Cb576e1d04d3b41a34dfe08d564128616%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636524953072637724&sdata=9kr6OISno%2Fck9pEyJv1e%2F0N7I86%2BDM%2BghWHerq9B7%2Fw%3D&reserved=0> is the likely culprit. I think @jashook<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjashook&data=02%7C01%7Cmikem%40microsoft.com%7Cb576e1d04d3b41a34dfe08d564128616%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636524953072637724&sdata=MvgmTFAWU78eBA%2F0%2Bl70q2C%2BigCQzrYdkiou%2BdNFvzk%3D&reserved=0> or @Samsung<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsamsung&data=02%7C01%7Cmikem%40microsoft.com%7Cb576e1d04d3b41a34dfe08d564128616%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636524953072637724&sdata=Cq5fv2BA70w%2BgPF0IdbtYWHlFnP2v5JF%2FwsCj3RMCSQ%3D&reserved=0> can help get you set up to debug in this environment if you can't figure it out with @jkotas<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjkotas&data=02%7C01%7Cmikem%40microsoft.com%7Cb576e1d04d3b41a34dfe08d564128616%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636524953072637724&sdata=w4bmfAyyAkLJw%2BJa1x7L%2FcWWb%2FXMxOhYbv68PaZuW%2F4%3D&reserved=0> thoughts. I would ask that you make it your top priority to investigate this and consider merging this PR if you can't, however. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fcoreclr%2Fpull%2F16007%23issuecomment-360524569&data=02%7C01%7Cmikem%40microsoft.com%7Cb576e1d04d3b41a34dfe08d564128616%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636524953072637724&sdata=clkiKZS%2F0dkDyykTlgT03lv5dS3p1UJlmrHF1jE3CDE%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJ-Fa4h0C9hxG1d2BdMd28tMs4OKn24Yks5tOK7JgaJpZM4RsK0w&data=02%7C01%7Cmikem%40microsoft.com%7Cb576e1d04d3b41a34dfe08d564128616%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636524953072637724&sdata=wtZDSaanINPIYWRlzT%2Fb5nzavABiclng9RjS1a7M99k%3D&reserved=0>.

benaadams · 2018-01-25T16:57:41Z

    CONTRACTL_END;

-    // Don't do anything if there is a native debugger already attached or the debugging support has been disabled.
-    if (IsDebuggerPresent() || m_pRCThread == NULL)


Aside, should this be reversed?

if (m_pRCThread == NULL || IsDebuggerPresent())

mikem8361 · 2018-01-25T17:07:12Z

It shouldn't matter. IsDebuggerPresent a API call to Windows.

RussKeldorph · 2018-01-25T19:14:44Z

CentOS Release failure is #16016. Merging per above. We can debug as time allows and make another pull request when ready. @lt72 FYI

Revert "Add environment variable (COMPlus_EnableDiagnostics) to disab…

8e42b4c

…le debugging and profiling. (#15878)" This reverts commit 5bcfde4.

RussKeldorph added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 25, 2018

jkotas reviewed Jan 25, 2018

View reviewed changes

benaadams reviewed Jan 25, 2018

View reviewed changes

RussKeldorph removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 25, 2018

RussKeldorph changed the title ~~[WIP] Revert "Add environment variable (COMPlus_EnableDiagnostics) to disab…~~ Revert "Add environment variable (COMPlus_EnableDiagnostics) to disab… Jan 25, 2018

RussKeldorph merged commit e998512 into dotnet:master Jan 25, 2018

RussKeldorph deleted the revert15878 branch January 25, 2018 19:14


		RaiseStartupNotification();

		// Also initialize the AppDomainEnumerationIPCBlock

Conversation

RussKeldorph commented Jan 25, 2018

Uh oh!

jkotas Jan 25, 2018

Choose a reason for hiding this comment

Uh oh!

mikem8361 Jan 25, 2018

Choose a reason for hiding this comment

Uh oh!

jkotas Jan 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkotas Jan 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benaadams commented Jan 25, 2018

Uh oh!

mikem8361 commented Jan 25, 2018

Uh oh!

benaadams commented Jan 25, 2018

Uh oh!

mikem8361 commented Jan 25, 2018 via email

Uh oh!

jkotas commented Jan 25, 2018

Uh oh!

RussKeldorph commented Jan 25, 2018

Uh oh!

mikem8361 commented Jan 25, 2018 via email

Uh oh!

benaadams Jan 25, 2018

Choose a reason for hiding this comment

Uh oh!

mikem8361 commented Jan 25, 2018 via email

Uh oh!

RussKeldorph commented Jan 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jkotas Jan 25, 2018 •

edited

Loading

jkotas Jan 25, 2018 •

edited

Loading