Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively (master) by dotnet-maestro-bot · Pull Request #16091 · dotnet/coreclr

dotnet-maestro-bot · 2018-01-30T02:47:30Z

/cc @dotnet/coreclr-auto-update-notify

dotnet-maestro-bot · 2018-01-30T02:59:32Z

Discarded e80d3fd: Update BuildTools, CoreClr to prerelease-02430-02, preview2-26130-01, respectively

CI Status: 2:x: 9:hourglass: 4:heavy_check_mark: (click to expand)

❌ CentOS7.1 x64 Debug Innerloop Build Build finished. Details
❌ Ubuntu arm64 Cross Debug Innerloop Build Build finished. Details
⌛ Alpine.3.6 x64 Debug Build Started Details
⌛ CentOS7.1 x64 Checked Innerloop Build and Test Started. Details
⌛ OSX10.12 x64 Checked Innerloop Build and Test.* Started. Details
⌛ Tizen armel Cross Checked Innerloop Build and Test Triggered. (13/28 on ubuntu1404-20170120)
⌛ Ubuntu x64 Checked Innerloop Build and Test.* Started. Details
⌛ Ubuntu x64 Formatting Triggered. (2/14 on ubuntu1404-20170925)
⌛ Windows_NT x64 Checked Innerloop Build and Test Started. Details
⌛ Windows_NT x86 Checked Innerloop Build and Test Started. Details
⌛ Windows_NT x86 Release Innerloop Build and Test Started. Details
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ Windows_NT x64 Formatting Build finished. Details
✔️ WIP ready for review Details

dotnet-maestro-bot · 2018-01-30T03:43:40Z

Discarded d03b1f1: Update BuildTools, CoreClr to prerelease-02430-02, preview2-26130-01, respectively

CI Status: 4:x: 7:hourglass: 4:heavy_check_mark: (click to expand)

❌ Alpine.3.6 x64 Debug Build Build finished. Details
❌ CentOS7.1 x64 Debug Innerloop Build Build finished. Details
❌ Ubuntu arm64 Cross Debug Innerloop Build Build finished. Details
❌ Ubuntu x64 Formatting Build finished. Details
⌛ CentOS7.1 x64 Checked Innerloop Build and Test Started. Details
⌛ OSX10.12 x64 Checked Innerloop Build and Test.* Started. Details
⌛ Tizen armel Cross Checked Innerloop Build and Test Triggered. (17/28 on ubuntu1404-20170120)
⌛ Ubuntu x64 Checked Innerloop Build and Test.* Started. Details
⌛ Windows_NT x64 Checked Innerloop Build and Test Started. Details
⌛ Windows_NT x86 Checked Innerloop Build and Test Started. Details
⌛ Windows_NT x86 Release Innerloop Build and Test Started. Details
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ Windows_NT x64 Formatting Build finished. Details
✔️ WIP ready for review Details

dotnet-maestro-bot · 2018-01-30T04:33:42Z

Discarded d0cd001: Update BuildTools, CoreClr to prerelease-02430-02, preview2-26130-01, respectively

CI Status: 6:x: 1:hourglass: 7:heavy_check_mark: (click to expand)

❌ CentOS7.1 x64 Checked Innerloop Build and Test Build finished. Details
❌ CentOS7.1 x64 Debug Innerloop Build Build finished. Details
❌ OSX10.12 x64 Checked Innerloop Build and Test.* Build finished. Details
❌ Ubuntu arm64 Cross Debug Innerloop Build Build finished. Details
❌ Ubuntu x64 Checked Innerloop Build and Test.* Build finished. Details
❌ Ubuntu x64 Formatting Build finished. Details
⌛ Tizen armel Cross Checked Innerloop Build and Test Triggered. (16/21 on ubuntu1404-20170120)
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ Windows_NT x64 Checked Innerloop Build and Test Build finished. Details
✔️ Windows_NT x64 Formatting Build finished. Details
✔️ Windows_NT x86 Checked Innerloop Build and Test Build finished. Details
✔️ Windows_NT x86 Release Innerloop Build and Test Build finished. Details
✔️ WIP ready for review Details

dotnet-maestro-bot · 2018-01-30T09:03:53Z

Discarded 0c46d0d: Update BuildTools, CoreClr, CoreFx to prerelease-02430-02, preview2-26130-01, preview2-26130-01, respectively

CI Status: 11:x: 4:heavy_check_mark: (click to expand)

❌ Alpine.3.6 x64 Debug Build Build finished. Details
❌ CentOS7.1 x64 Checked Innerloop Build and Test Build finished. Details
❌ CentOS7.1 x64 Debug Innerloop Build Build finished. Details
❌ OSX10.12 x64 Checked Innerloop Build and Test.* Build finished. Details
❌ Tizen armel Cross Checked Innerloop Build and Test Build finished. Details
❌ Ubuntu arm64 Cross Debug Innerloop Build Build finished. Details
❌ Ubuntu x64 Checked Innerloop Build and Test.* Build finished. Details
❌ Ubuntu x64 Formatting Build finished. Details
❌ Windows_NT x64 Checked Innerloop Build and Test Build finished. Details
❌ Windows_NT x86 Checked Innerloop Build and Test Build finished. Details
❌ Windows_NT x86 Release Innerloop Build and Test Build finished. Details
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ Windows_NT x64 Formatting Build finished. Details
✔️ WIP ready for review Details

dotnet-maestro-bot · 2018-01-30T13:43:17Z

Discarded 55f388b: Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-02, preview2-26130-01, preview2-26130-01, master-20180130-0046, respectively

CI Status: 2:x: 2:heavy_check_mark: (click to expand)

❌ Alpine.3.6 x64 Debug Build Build finished. Details
❌ Windows_NT x86 Checked Innerloop Build and Test Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ WIP ready for review Details

dotnet-maestro-bot · 2018-01-30T17:54:58Z

Discarded 1e3be52: Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-02, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively

CI Status: 6:x: 3:heavy_check_mark: (click to expand)

❌ Alpine.3.6 x64 Debug Build Build finished. Details
❌ CentOS7.1 x64 Checked Innerloop Build and Test Build finished. Details
❌ OSX10.12 x64 Checked Innerloop Build and Test.* Build finished. Details
❌ Tizen armel Cross Checked Innerloop Build and Test Build finished. Details
❌ Windows_NT x64 Checked Innerloop Build and Test Build finished. Details
❌ Windows_NT x86 Checked Innerloop Build and Test Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ Windows_NT x64 Formatting Build finished. Details
✔️ WIP ready for review Details

joperezr · 2018-01-30T18:02:25Z

CI is failing because buildtools, since the update will require extra changes I'm working on right now. I'll send out a separate PR for that and unblock this one.

dotnet-maestro-bot · 2018-01-30T18:12:57Z

Discarded 09218ae: Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively

CI Status: 3:x: 9:hourglass: 3:heavy_check_mark: (click to expand)

❌ Alpine.3.6 x64 Debug Build Build finished. Details
❌ CentOS7.1 x64 Debug Innerloop Build Build finished. Details
❌ Ubuntu arm64 Cross Debug Innerloop Build Build finished. Details
⌛ CentOS7.1 x64 Checked Innerloop Build and Test Started. Details
⌛ OSX10.12 x64 Checked Innerloop Build and Test.* Started. Details
⌛ Tizen armel Cross Checked Innerloop Build and Test Triggered. (18/25 on ubuntu1404-20170120)
⌛ Ubuntu x64 Checked Innerloop Build and Test.* Started. Details
⌛ Ubuntu x64 Formatting Started. Details
⌛ Windows_NT x64 Checked Innerloop Build and Test Started. Details
⌛ Windows_NT x64 Formatting Started. Details
⌛ Windows_NT x86 Checked Innerloop Build and Test Started. Details
⌛ Windows_NT x86 Release Innerloop Build and Test Started. Details
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ WIP ready for review Details

joperezr · 2018-01-30T18:27:17Z

Buildtools update handled by: #16101

joperezr · 2018-01-30T19:28:32Z

The remaining failures are not buildtools related, they seem to be caused by the corefx ingestion. cc: @jkotas @stephentoub

jkotas · 2018-01-30T20:08:13Z

'Span' does not contain a definition for 'DangerousCreate'

@ianhays This is fallout from your change. Could you please fix amend this PR with a change to fix these build breaks?

dotnet-maestro-bot · 2018-01-30T21:23:09Z

Couldn't update this pull request: Head commit author 'Jose Perez Rodriguez' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-05, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively'

dotnet-maestro-bot · 2018-01-31T00:16:55Z

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-05, preview2-26130-05, preview2-26130-01, master-20180130-1600, respectively'

dotnet-maestro-bot · 2018-01-31T01:26:24Z

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02431-01, preview2-26131-01, preview2-26130-01, master-20180130-1600, respectively'

dotnet-maestro-bot · 2018-01-31T01:40:12Z

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02431-01, preview2-26131-01, preview2-26130-01, master-20180130-1600, respectively'

ianhays · 2018-01-31T02:01:03Z

Still seeing the same issues from #16086 with CreateSpan missing.

jkotas · 2018-01-31T02:11:29Z

The perf tests are build against .NET Standard 1.4 for some reason: https://github.com/dotnet/coreclr/blob/master/tests/src/JIT/config/benchmark/benchmark.csproj#L5

CreateSpan APIs are .NET Core 2.1 only, and that's why it cannot find them.

I would recommend putting the CreateSpan benchmark under #if false to get this through, and open issue on it. I am not sure what would be the perf team preference to deal with this.

cc @valenis

dotnet-maestro-bot · 2018-01-31T02:20:04Z

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02431-02, preview2-26131-01, preview2-26130-01, master-20180130-1600, respectively'

dotnet-maestro-bot · 2018-01-31T02:38:27Z

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02431-02, preview2-26131-01, preview2-26131-01, master-20180130-1600, respectively'

dotnet-maestro-bot · 2018-01-31T08:51:26Z

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02431-02, preview2-26131-01, preview2-26131-01, master-20180131-0033, respectively'

dotnet-maestro-bot · 2018-01-31T13:28:53Z

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02431-02, preview2-26131-05, preview2-26131-01, master-20180131-0033, respectively'

dotnet-maestro-bot · 2018-01-31T15:38:12Z

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02431-02, preview2-26131-05, preview2-26131-05, master-20180131-0033, respectively'

ianhays · 2018-01-31T16:19:59Z

@jkotas @joperezr would one of you mind please turning off the CreateSpan perf tests for me? I'm out sick.

jkotas · 2018-01-31T17:04:50Z

I will take care of it.

…review2-26130-05, preview2-26130-01, master-20180130-0046, respectively

dotnet-maestro-bot · 2018-01-31T18:43:06Z

Couldn't update this pull request: Head commit author 'Jan Kotas' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02431-04, preview2-26131-05, preview2-26131-05, master-20180131-0033, respectively'

…r-UpdateDependencies Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively (master) Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>

…r-UpdateDependencies Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively (master) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

A few parts of SpanBench were disabled in dotnet#16091 as we were compiling the benchmarks with more restrictive netstandard versions and some APIs were moved to be netcoreapp 2.1 only. With the advent of dotnet#16378 we've removed those restrictions so the tests can be re-enabled.

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from ae60646 to e80d3fd Compare January 30, 2018 02:47

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from e80d3fd to d03b1f1 Compare January 30, 2018 02:59

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from d03b1f1 to d0cd001 Compare January 30, 2018 03:43

dotnet-maestro-bot changed the title ~~Update BuildTools, CoreClr to prerelease-02430-02, preview2-26130-01, respectively (master)~~ Update BuildTools, CoreClr, CoreFx to prerelease-02430-02, preview2-26130-01, preview2-26130-01, respectively (master) Jan 30, 2018

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from d0cd001 to 0c46d0d Compare January 30, 2018 04:34

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 0c46d0d to 55f388b Compare January 30, 2018 09:04

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 55f388b to 1e3be52 Compare January 30, 2018 13:43

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 1e3be52 to 09218ae Compare January 30, 2018 17:55

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 09218ae to 8e37009 Compare January 30, 2018 18:13

jkotas mentioned this pull request Jan 30, 2018

Remove replaced Span/ReadOnlySpan methods. #16086

Closed

dotnet-maestro-bot and others added 4 commits January 31, 2018 09:26

Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, p…

7b532ab

…review2-26130-05, preview2-26130-01, master-20180130-0046, respectively

Remove replaced Span/ReadOnlySpan methods.

93ec623

Remove Span DangerousGetPinnableReference

f67b410

Disable MemoryMarshal.CreateSpan tests

ddc88f3

jkotas force-pushed the master-UpdateDependencies branch from 6181db1 to ddc88f3 Compare January 31, 2018 17:33

jkotas merged commit a6d7f16 into dotnet:master Jan 31, 2018

AndyAyersMS mentioned this pull request Feb 27, 2018

Re-enable parts of SpanBench #16630

Closed

jkotas mentioned this pull request Jan 31, 2020

Update performance tests to build against netcoreapp dotnet/runtime#9635

Closed

Conversation

dotnet-maestro-bot commented Jan 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-maestro-bot commented Jan 30, 2018

Uh oh!

dotnet-maestro-bot commented Jan 30, 2018

Uh oh!

dotnet-maestro-bot commented Jan 30, 2018

Uh oh!

dotnet-maestro-bot commented Jan 30, 2018

Uh oh!

dotnet-maestro-bot commented Jan 30, 2018

Uh oh!

dotnet-maestro-bot commented Jan 30, 2018

Uh oh!

joperezr commented Jan 30, 2018

Uh oh!

dotnet-maestro-bot commented Jan 30, 2018

Uh oh!

joperezr commented Jan 30, 2018

Uh oh!

joperezr commented Jan 30, 2018

Uh oh!

jkotas commented Jan 30, 2018

Uh oh!

dotnet-maestro-bot commented Jan 30, 2018

Uh oh!

dotnet-maestro-bot commented Jan 31, 2018

Uh oh!

dotnet-maestro-bot commented Jan 31, 2018

Uh oh!

dotnet-maestro-bot commented Jan 31, 2018

Uh oh!

ianhays commented Jan 31, 2018

Uh oh!

jkotas commented Jan 31, 2018

Uh oh!

dotnet-maestro-bot commented Jan 31, 2018

Uh oh!

dotnet-maestro-bot commented Jan 31, 2018

Uh oh!

dotnet-maestro-bot commented Jan 31, 2018

Uh oh!

dotnet-maestro-bot commented Jan 31, 2018

Uh oh!

dotnet-maestro-bot commented Jan 31, 2018

Uh oh!

ianhays commented Jan 31, 2018

Uh oh!

jkotas commented Jan 31, 2018

Uh oh!

dotnet-maestro-bot commented Jan 31, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dotnet-maestro-bot commented Jan 30, 2018 •

edited

Loading