Move windows agents to DotNetCore-Build

[MattGal]

@vancem , @jashook FYI. If CoreCLR can build in a VS2017-only environment now, this should be all that's left to make that happen.

Ping me for guidance on testing this if needed.

[jashook]

Will start testing the changes.

/cc @RussKeldorph @vancem

[jashook]

Started https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1461205&_a=summary.

[jashook]

Run failed due to not having msdia120.dll registered. Marking as no merge until the machines are setup correctly.

[vancem]

This is likely related to this issue were the DacTableGen is using a old version of msdia (and VS 2017 does not register it by default (but it does carry the DLL).

https://github.com/dotnet/coreclr/issues/11305#issuecomment-343009330

This hit developers who set up clean machines with just VS 2017 (which is probably what is happening on the build machines.

Fixing DacTableGen (that is issue 11305) would be nice, but it relies on very old nuget packages that may take some effort to update (even finding their source code was non-trivial).

Instead as a work-around we added the following to build.cmd which tests if msdia120.dll was registered and if not tells the user how to do this (you need elevation to run the command, and we did not want builds to require elevation).

REM Make the work-around to a bug in the microsoft.dotnet.buildtools.coreclr package until it is fixed.  
reg query HKEY_CLASSES_ROOT\WOW6432Node\CLSID\{3BFCEA48-620F-4B6B-81F7-B9AF75454C7D}\InprocServer32 > NUL: 2>&1
if NOT '%ERRORLEVEL%' == '0' (
    echo.
    echo.**********************************************************************************
    echo.Error: We have detected that the msdia120.dll is not registered.   
    echo.This is necessary for the build to complete without a Class_Not_Registered error.
    echo.
    echo.You can fix this by 
    echo.  1. Launching the "Developer Command Prompt for VS2017" with Administrative privileges
    echo.  2. Running  regsvr32.exe "%%VSINSTALLDIR%%\Common7\IDE\msdia120.dll"  
    echo.
    echo.This will only need to be done once for the lifetime of the machine.
    echo.For more details see: https://github.com/dotnet/coreclr/issues/11305
    exit /b 1
)

Notice this gives the instructions (a regsvr32.exe command) that can be run on these machines (it only needs to run once, but it is OK if runs many times), that registers a copy of msdia120.dll that lives with the VS2017 distribution.

Can someone with more knowledge of the machine setup scripts comment? A simple work-around would be to add this regsvr32 command to the setup scripts (or event the build scripts.

[vancem]

PR #17004 should resolve the failure because of msdia120.dll

@jashook can you see if we succeed now?

[jashook]

https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1492289&_a=summary started

[MattGal]

Ready to merge, clean build using 2017 agents: https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1508454&_a=summary

[vancem]

We ran a private build of this and it worked.
I think we are good to go.

[vancem]

LGTM