Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Convert Sse2 tests to templated version - part 1#16967

Merged
tannergooding merged 1 commit into
dotnet:masterfrom
dotnetrt:Sse2TestConversion1
Mar 16, 2018
Merged

Convert Sse2 tests to templated version - part 1#16967
tannergooding merged 1 commit into
dotnet:masterfrom
dotnetrt:Sse2TestConversion1

Conversation

@4creators
Copy link
Copy Markdown

This is first part of conversion work for Sse2 tests.

@4creators 4creators force-pushed the Sse2TestConversion1 branch from f8ea208 to e25bced Compare March 15, 2018 18:04
@4creators
Copy link
Copy Markdown
Author

@CarolEidt @fiigii @tannergooding PTAL

@fiigii
Copy link
Copy Markdown

fiigii commented Mar 15, 2018

Thanks for the work, but you may want to wait for #16957

@4creators
Copy link
Copy Markdown
Author

4creators commented Mar 15, 2018

Thanks for the work, but you may want to wait for #16957

#16957 could be applied before or after merging this PR in next part of conversions which I plan to commit soon. It affects only couple of converted tests.

@4creators 4creators force-pushed the Sse2TestConversion1 branch from e25bced to 553ccd7 Compare March 15, 2018 19:01
@4creators
Copy link
Copy Markdown
Author

test Windows_NT x64 Checked jitincompletehwintrinsic
test Windows_NT x64 Checked jitx86hwintrinsicnoavx2
test Windows_NT x64 Checked jitx86hwintrinsicnosimd
test Windows_NT x64 Checked jitnox86hwintrinsic

test Windows_NT x86 Checked jitincompletehwintrinsic
test Windows_NT x86 Checked jitx86hwintrinsicnoavx2
test Windows_NT x86 Checked jitx86hwintrinsicnosimd
test Windows_NT x86 Checked jitnox86hwintrinsic

test Ubuntu x64 Checked jitincompletehwintrinsic
test Ubuntu x64 Checked jitx86hwintrinsicnoavx2
test Ubuntu x64 Checked jitx86hwintrinsicnosimd
test Ubuntu x64 Checked jitnox86hwintrinsic

Copy link
Copy Markdown

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I defer to @tannergooding regarding whether to wait for #16957

@tannergooding
Copy link
Copy Markdown
Member

I'm going to merge this and fixup #16957, since I need to resolve the remaining GCStress test issues anyways

@tannergooding tannergooding merged commit d440b16 into dotnet:master Mar 16, 2018
@4creators
Copy link
Copy Markdown
Author

@tannergooding Thanks

@4creators 4creators deleted the Sse2TestConversion1 branch March 16, 2018 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants