Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Use INS_mvsdsse2 for SSE2_ConvertToDouble#17263

Closed
CarolEidt wants to merge 1 commit into
dotnet:masterfrom
CarolEidt:Fix17261
Closed

Use INS_mvsdsse2 for SSE2_ConvertToDouble#17263
CarolEidt wants to merge 1 commit into
dotnet:masterfrom
CarolEidt:Fix17261

Conversation

@CarolEidt
Copy link
Copy Markdown

Fix #17261

@CarolEidt
Copy link
Copy Markdown
Author

@dotnet-bot test Windows_NT x86 Checked jitstressregs4

@CarolEidt
Copy link
Copy Markdown
Author

@dotnet/jit-contrib @tannergooding @4creators @fiigii PTAL

@mikedn
Copy link
Copy Markdown

mikedn commented Mar 27, 2018

Maybe we should rename INS_movsd to INS_movs_dword to avoid such confusions...

@4creators
Copy link
Copy Markdown

Maybe we should rename INS_movsd to INS_movs_dword to avoid such confusions...

This type of confusions in theory should not happen but there are three "problems" in instrxarch.h that could be addressed: (i) duplicate names of instructions from Intel manual which could disambiguated, (ii) ordering of instructions by (i) functionality followed by (ii) alphabetical.

@AndyAyersMS
Copy link
Copy Markdown
Member

Isn't this the same fix as in #17110?

@fiigii
Copy link
Copy Markdown

fiigii commented Mar 27, 2018

Isn't this the same fix as in #17110?

I think so...

@CarolEidt
Copy link
Copy Markdown
Author

Ah, I missed that.

@CarolEidt CarolEidt closed this Mar 27, 2018
@CarolEidt CarolEidt deleted the Fix17261 branch July 16, 2018 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants